-
Notifications
You must be signed in to change notification settings - Fork 46
[Bugfix][zos_mount] added condition to skip fsumf168 during df call #2060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Rich Parker <[email protected]>
Signed-off-by: Rich Parker <[email protected]>
I switched this back to draft while working out a pipeline error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty straightforward. Looks good, just wondering if the changelog fragment should be a bugfix so that users are notified of this change
Signed-off-by: Rich Parker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested a minor change
@@ -0,0 +1,3 @@ | |||
bugfixes: | |||
- zos_mount - Added handling to the df call, so that FSUMF168 are ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try to stick to the ansible development process for change logs https://docs.ansible.com/ansible/latest/community/development_process.html . In this case this is the format we use
Fixes that resolve issues. SHOULD not be used for minor enhancements (use minor_change instead). Use past tense to describe the problem and present tense to describe the fix.
And since this bugfix will be client-facing it should be less technical more like "In some cases, df command would raise error FSUMF168 as a warning for certain cases(can add more details for those cases) and the module failed. Fix now handles this warning message gracefully and continues with the operation."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your comments make perfect sense for these cases :
FSUMF168 return in stderror means that the mount dataset wouldn't resolve.
# While this shows a catalog or volume issue, it should not impact our search for an existing mount
SUMMARY
added code in zos_mount to ignore an error return, if the return included FSUMF168 in the text of the df call.
Fiixes #1940
ISSUE TYPE
COMPONENT NAME
zos_mount.py
ADDITIONAL INFORMATION
Speaking with storage experts, it was determined this message was a warning, and that the data was still being retunred.