-
Notifications
You must be signed in to change notification settings - Fork 45
[Enabler][2294]Add_aliases_and_deprecation_messages_for_new_version #2353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging-v1.16.0-beta.1
Are you sure you want to change the base?
[Enabler][2294]Add_aliases_and_deprecation_messages_for_new_version #2353
Conversation
plugins/modules/zos_find.py
Outdated
|
||
if pds_paths is not None: | ||
module.deprecate( | ||
msg="The 'pds_pattern' parameter and aliases is deprecated and will be removed. Onnew version to serach for an specific member required regex isnide ()", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo? Onnew? The sentence is confusing as it stands.
plugins/modules/zos_job_output.py
Outdated
|
||
if ddname is not None: | ||
module.deprecate( | ||
msg="The 'ddname' parameter is deprecated and will be use as alias. Please use 'dd_name' instead.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use -> used
plugins/modules/zos_job_submit.py
Outdated
|
||
if module.params.get("location") is not None: | ||
module.deprecate( | ||
msg="The 'location' parameter will be drpecated Please use 'remote_src' instead. Logic will change to set if the document with the job is" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drpecated -> deprecated
plugins/modules/zos_operator.py
Outdated
|
||
if module.params.get('wait_time_s') is not None: | ||
module.deprecate( | ||
msg="The 'wait_time_s' parameter will be deprecated. Please use 'wait_time' instead. And option 'time_unit' will be added to set cs o seconds.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Third sentence should not start with 'And", and I'm confused by the words after 'set' in that sentence.
if module.params.get('message_filter') is not None: | ||
if module.params.get('message_filter').get('use_regex') is not None: | ||
module.deprecate( | ||
msg="The 'use_regex' parameter will be deprecated. Please use 'literal' instead. On new version will work on reverse logic being False to use as regex.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider at the end: "New version will use false to mean regex will be used".
plugins/modules/zos_unarchive.py
Outdated
|
||
if format_param.get('name') is not None: | ||
module.deprecate( | ||
msg="The 'format.name' parameter will be deperecated. On 2.0.0 version use 'format.type' instead.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have read a lot of messages, but this is the first time I've seen a version number. Maybe switch to "Please use...", like you do elsewhere.
SUMMARY
This is part of the task #2294 to ensure all is aligned and add the deprecation messages for 2.0.0 version.
ISSUE TYPE
COMPONENT NAME
Add module.deprecate or display.deprecate to ensure message as warning for arguments that will be deprecated or pass to be aliases on the 2.0.0 version of the collection.
ADDITIONAL INFORMATION
To see the full deprecation warning required the task to be complete or exit with a module.fail_json, other kind of error won't generate deprecation warnings.
Not all new name names could be use as aliases because generate match problems with other parameters such type on zos_archive and zos_unarchive. force option for zos_copy.
Playbook to test