Align helmdiff_check behavior with the deploy function
#670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 14s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 54s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 13s |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 48s |
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 17s |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 53s |
|
Hello @abikouo @alinabuzachis @gravesm, |
|
Thanks. Would you mind bumping the version in your PR? |
…id incompatability with new bitnami charts
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 6m 04s |
gravesm
approved these changes
Feb 19, 2024
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 39s |
softwarefactory-project-zuul
bot
merged commit 7c4ec3b
into
ansible-collections:main
46 checks passed
psmolkin
deleted the
bugfix/fix-cmd-render-differences-between-diff-and-deploy
branch
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #690 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
Align `helmdiff_check` behavior with the `deploy` function SUMMARY Align helmdiff_check behavior with the deploy function Fixes #638 helmdiff_check respects set_values parameter Fixes #669 helmdiff_check command line parameters sequence aligned to the deploy function ISSUE TYPE Bugfix Pull Request COMPONENT NAME kubernetes.core.helm Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 7c4ec3b)
abikouo
pushed a commit
that referenced
this pull request
Mar 1, 2024
Align `helmdiff_check` behavior with the `deploy` function SUMMARY Align helmdiff_check behavior with the deploy function Fixes #638 helmdiff_check respects set_values parameter Fixes #669 helmdiff_check command line parameters sequence aligned to the deploy function ISSUE TYPE Bugfix Pull Request COMPONENT NAME kubernetes.core.helm Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 7c4ec3b) Co-authored-by: psmolkin <[email protected]>
Merged
sp3nx0r
referenced
this pull request
in sp3nx0r/homelab
Jun 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [kubernetes.core](https://togithub.com/ansible-collections/kubernetes.core) | galaxy-collection | major | `3.0.1` -> `5.0.0` | --- ### Release Notes <details> <summary>ansible-collections/kubernetes.core (kubernetes.core)</summary> ### [`v5.0.0`](https://togithub.com/ansible-collections/kubernetes.core/blob/HEAD/CHANGELOG.rst#v500) [Compare Source](https://togithub.com/ansible-collections/kubernetes.core/compare/4.0.0...5.0.0) \====== ## Release Summary This major release drops support for `ansible-core<2.15`. ## Minor Changes - inventory/k8s.py - Defer removal of k8s inventory plugin to version 6.0.0 ([https://github.com/ansible-collections/kubernetes.core/pull/734](https://togithub.com/ansible-collections/kubernetes.core/pull/734)). ## Breaking Changes / Porting Guide - Remove support for `ansible-core<2.15` ([https://github.com/ansible-collections/kubernetes.core/pull/737](https://togithub.com/ansible-collections/kubernetes.core/pull/737)). ### [`v4.0.0`](https://togithub.com/ansible-collections/kubernetes.core/blob/HEAD/CHANGELOG.rst#v400) [Compare Source](https://togithub.com/ansible-collections/kubernetes.core/compare/3.2.0...4.0.0) \====== ## Release Summary This major release brings several bug fixes. We have also removed support for `ansible-core<2.15` and deprecated functions and class from `module_utils/common.py`. ## Minor Changes - inventory/k8s.py - Defer removal of k8s inventory plugin to version 5.0 ([https://github.com/ansible-collections/kubernetes.core/pull/723](https://togithub.com/ansible-collections/kubernetes.core/pull/723)). - k8s - The module and K8sService were changed so warnings returned by the K8S API are now displayed to the user. ## Removed Features (previously deprecated) - k8s - Support for `merge_type=json` has been removed in version 4.0.0. Please use `kubernetes.core.k8s_json_patch` instead ([https://github.com/ansible-collections/kubernetes.core/pull/722](https://togithub.com/ansible-collections/kubernetes.core/pull/722)). - k8s_exec - the previously deprecated `result.return_code` return value has been removed, consider using `result.rc` instead ([https://github.com/ansible-collections/kubernetes.core/pull/726](https://togithub.com/ansible-collections/kubernetes.core/pull/726)). - module_utils/common.py - the previously deprecated `K8sAnsibleMixin` class has been removed ([https://github.com/ansible-collections/kubernetes.core/pull/726](https://togithub.com/ansible-collections/kubernetes.core/pull/726)). - module_utils/common.py - the previously deprecated `configuration_digest()` function has been removed ([https://github.com/ansible-collections/kubernetes.core/pull/726](https://togithub.com/ansible-collections/kubernetes.core/pull/726)). - module_utils/common.py - the previously deprecated `get_api_client()` function has been removed ([https://github.com/ansible-collections/kubernetes.core/pull/726](https://togithub.com/ansible-collections/kubernetes.core/pull/726)). - module_utils/common.py - the previously deprecated `unique_string()` function has been removed ([https://github.com/ansible-collections/kubernetes.core/pull/726](https://togithub.com/ansible-collections/kubernetes.core/pull/726)). ## Bugfixes - Resolve Collections util resource discovery fails when complex subresources present ([https://github.com/ansible-collections/kubernetes.core/pull/676](https://togithub.com/ansible-collections/kubernetes.core/pull/676)). - align `helmdiff_check()` function commandline rendering with the `deploy()` function ([https://github.com/ansible-collections/kubernetes.core/pull/670](https://togithub.com/ansible-collections/kubernetes.core/pull/670)). - avoid unsafe conditions in integration tests ([https://github.com/ansible-collections/kubernetes.core/pull/665](https://togithub.com/ansible-collections/kubernetes.core/pull/665)). - helm - use `reuse-values` when running `helm diff` command ([https://github.com/ansible-collections/kubernetes.core/issues/680](https://togithub.com/ansible-collections/kubernetes.core/issues/680)). - integrations test helm_kubeconfig - set helm version to v3.10.3 to avoid incompatability with new bitnami charts ([https://github.com/ansible-collections/kubernetes.core/pull/670](https://togithub.com/ansible-collections/kubernetes.core/pull/670)). ### [`v3.2.0`](https://togithub.com/ansible-collections/kubernetes.core/compare/3.1.0...3.2.0) [Compare Source](https://togithub.com/ansible-collections/kubernetes.core/compare/3.1.0...3.2.0) ### [`v3.1.0`](https://togithub.com/ansible-collections/kubernetes.core/blob/HEAD/CHANGELOG.rst#v310) [Compare Source](https://togithub.com/ansible-collections/kubernetes.core/compare/3.0.1...3.1.0) \====== ## Release Summary This release comes with some bugfixes and documentation updates. It also adds new features to the kubectl connection plugin and the kustomize lookup plugin. ## Minor Changes - kubectl - added support of local enviroment variable that will be used for kubectl and may be requried for establishing connections ifself ([https://github.com/ansible-collections/kubernetes.core/pull/702](https://togithub.com/ansible-collections/kubernetes.core/pull/702)) - kustomize - new parameter added to --enable-helm ([https://github.com/ansible-collections/kubernetes.core/issues/568](https://togithub.com/ansible-collections/kubernetes.core/issues/568)) ## Bugfixes - helm - expand kubeconfig path with user's home directory for consistency with k8s - k8s_json_patch - rename action symlink to ensure k8s action plugin is used ([https://github.com/ansible-collections/kubernetes.core/pull/652](https://togithub.com/ansible-collections/kubernetes.core/pull/652)). </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sp3nx0r/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9hbnNpYmxlIiwidHlwZS9tYWpvciJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Align
helmdiff_checkbehavior with thedeployfunctionhelmdiff_checkrespectsset_valuesparameterhelmdiff_checkcommand line parameters sequence aligned to thedeployfunctionISSUE TYPE
COMPONENT NAME
kubernetes.core.helm