Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of local environment variables in kustomize lookup plugin #786

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

yurnov
Copy link
Contributor

@yurnov yurnov commented Oct 30, 2024

SUMMARY

kustomize doesn't support an environment that makes it impossible to use HTTP_PROXY or provide some templatized parameters.

This PR is the result of the issue #783

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

kubernetes.core.kustomize lookup plugin

Copy link

Copy link

@yurnov yurnov changed the title Add support of local environment variables in kustomize lookup plugin [WIP] Add support of local environment variables in kustomize lookup plugin Oct 30, 2024
Copy link

Copy link

Copy link

Copy link

@yurnov yurnov force-pushed the support_local_env_for_kustomize branch from f67c998 to f0691f5 Compare October 30, 2024 14:13
Copy link

@yurnov yurnov changed the title [WIP] Add support of local environment variables in kustomize lookup plugin Add support of local environment variables in kustomize lookup plugin Oct 30, 2024
@yurnov
Copy link
Contributor Author

yurnov commented Oct 30, 2024

Hi @abikouo,

could you please check for workflow, some sanity tests are failing on milestone and development and it seems that it is unrelated to this PR reason.

Copy link

Copy link

Copy link

Copy link

@yurnov yurnov force-pushed the support_local_env_for_kustomize branch 3 times, most recently from 5cfb0ac to c4cd490 Compare November 21, 2024 20:41
Copy link

@yurnov yurnov force-pushed the support_local_env_for_kustomize branch from c4cd490 to fbfcadf Compare November 21, 2024 20:58
Copy link

@yurnov yurnov force-pushed the support_local_env_for_kustomize branch 2 times, most recently from 1f49306 to 8983d31 Compare November 21, 2024 23:59
Copy link

@yurnov yurnov force-pushed the support_local_env_for_kustomize branch 3 times, most recently from fc8b233 to cdebfec Compare November 22, 2024 00:25
Copy link

@yurnov yurnov force-pushed the support_local_env_for_kustomize branch from cdebfec to a54156f Compare November 22, 2024 00:38
Copy link

@yurnov yurnov force-pushed the support_local_env_for_kustomize branch from a54156f to 872d4db Compare November 22, 2024 08:29
Copy link

@yurnov yurnov force-pushed the support_local_env_for_kustomize branch 2 times, most recently from 687d0a0 to a238296 Compare November 22, 2024 08:50
@yurnov yurnov force-pushed the support_local_env_for_kustomize branch from a238296 to 4eded57 Compare November 22, 2024 09:02
@yurnov yurnov requested a review from abikouo November 22, 2024 09:11
@yurnov
Copy link
Contributor Author

yurnov commented Nov 22, 2024

Hi @abikouo,

I have fixed the typo, considered your suggestion, and added integration tests with positive and negative scenarios. Please review PR again.

For unclear reasons, kubevirt test is failing.

Copy link

Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants