Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo #804

Merged
merged 3 commits into from
Dec 17, 2024
Merged

fix: typo #804

merged 3 commits into from
Dec 17, 2024

Conversation

pierreozoux
Copy link
Contributor

replaces #799

@pierreozoux pierreozoux mentioned this pull request Dec 6, 2024
Closed
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ecd298c73c08488e800fab717f238a1c

✔️ ansible-galaxy-importer SUCCESS in 4m 21s
✔️ build-ansible-collection SUCCESS in 5m 19s

@yurnov
Copy link
Contributor

yurnov commented Dec 12, 2024

Hi @pierreozoux,

could you please add a changelog fragment?

@pierreozoux
Copy link
Contributor Author

@yurnov ok like this?

@gravesm
Copy link
Member

gravesm commented Dec 13, 2024

Docs changes do not actually need a change log. If you want to provide one, it should be trivial instead of bugfixes.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b2e3080e603841c0a305274b21404ee2

✔️ ansible-galaxy-importer SUCCESS in 3m 23s
✔️ build-ansible-collection SUCCESS in 5m 40s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/101e05c6a1e1468d9388f00f9df7364c

✔️ ansible-galaxy-importer SUCCESS in 3m 16s
✔️ build-ansible-collection SUCCESS in 5m 24s

@abikouo abikouo merged commit 219c747 into ansible-collections:main Dec 17, 2024
42 checks passed
@patchback Patchback
Copy link

patchback bot commented Dec 17, 2024 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/219c747a24a78bd072e1f54edd6d707efab02597/pr-804

Backported as #834

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 17, 2024
@pierreozoux @patchback
fix: typo (#804)
e98bb1c 
* fix: typo

replaces #799

* doc: add changelog fragment

* Delete changelogs/fragments/804-drain-typo.yaml

---------

Co-authored-by: Bikouo Aubin <[email protected]>
(cherry picked from commit 219c747)
@patchback patchback bot mentioned this pull request Dec 17, 2024
Merged
@pierreozoux pierreozoux deleted the pierreozoux-patch-2 branch December 17, 2024 11:36
@pierreozoux
Copy link
Contributor Author

\o/

🙏

danke!

abikouo pushed a commit that referenced this pull request Dec 17, 2024
@patchback @pierreozoux
fix: typo (#804) (#834)
f1729ce 
* fix: typo

replaces #799

* doc: add changelog fragment

* Delete changelogs/fragments/804-drain-typo.yaml

---------

Co-authored-by: Bikouo Aubin <[email protected]>
(cherry picked from commit 219c747)

Co-authored-by: Pierre Ozoux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo abikouo approved these changes

Assignees
No one assigned
Labels
backport-5 skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pierreozoux @yurnov @gravesm @abikouo