[PR #793/fca0dc04 backport][stable-3] Fix k8s_drain runs into timeout with pods from stateful sets. #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 28s |
SUMMARY Fixes #792 . The function wait_for_pod_deletion in k8s_drain never checks on which node a pod is actually running: try: response = self._api_instance.read_namespaced_pod( namespace=pod[0], name=pod[1] ) if not response: pod = None time.sleep(wait_sleep) This means that if a pod is successfully evicted and restarted with the same name on a new node, k8s_drain does not notice and thinks that the original pod is still running. This is the case for pods which are part of a stateful set. ISSUE TYPE Bugfix Pull Request COMPONENT NAME k8s_drain Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit fca0dc0)
gravesm
force-pushed
the
patchback/backports/stable-3/fca0dc0485bf3748b61ac547957617e1e66573be/pr-793
branch
from
0684451 to
61d298d
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 2m 57s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 18s |
gravesm
deleted the
patchback/backports/stable-3/fca0dc0485bf3748b61ac547957617e1e66573be/pr-793
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #793 as merged into main (fca0dc0).
SUMMARY
Fixes #792 .
The function
wait_for_pod_deletionin k8s_drain never checks on which node a pod is actually running:This means that if a pod is successfully evicted and restarted with the same name on a new node,
k8s_draindoes not notice and thinks that the original pod is still running. This is the case for pods which are part of a stateful set.ISSUE TYPE
COMPONENT NAME
k8s_drain