Fix helm integration tests #830

abikouo · 2024-12-16T09:17:17Z

SUMMARY

Fix charts ref on integration tests targets

ISSUE TYPE

Bugfix Pull Request

yurnov

a test tests/integration/targets/helm_kubeconfig/tasks/tests_helm_auth.yml should be changed:

    # helm_repository, helm, helm_info
    - name: Add test_bitnami chart repository
      helm_repository:
        binary_path: "{{ helm_binary }}"
        name: test_bitnami
        kubeconfig: "{{ test_kubeconfig | default(omit) }}"
        validate_certs: "{{ test_validate_certs | default(omit) }}"
        ca_cert: "{{ test_ca_cert | default(omit) }}"
        repo_url: https://charts.bitnami.com/bitnami
      register: repository

is failing due to:

curl -I https://charts.bitnami.com/bitnami/index.yaml
curl: (6) Could not resolve host: charts.bitnami.com

softwarefactory-project-zuul · 2024-12-16T09:32:39Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5b12db0ba97242639ef14e27a08f0763

✔️ ansible-galaxy-importer SUCCESS in 8m 58s
✔️ build-ansible-collection SUCCESS in 5m 21s

yurnov · 2024-12-16T09:37:46Z

Hi @abikouo

please replace https://charts.bitnami.com/bitnami with https://raw.githubusercontent.com/bitnami/charts/a03edc0cc5dbae9c9bc5e16be45933373ccdfe44/bitnami everywhere, it should help.

softwarefactory-project-zuul · 2024-12-16T10:02:51Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/27861681896d45d6b2b8df83975eb095

✔️ ansible-galaxy-importer SUCCESS in 5m 08s
✔️ build-ansible-collection SUCCESS in 5m 22s

softwarefactory-project-zuul · 2024-12-16T11:27:26Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/cc68d85badf345f983cb571a7a6e3b13

✔️ ansible-galaxy-importer SUCCESS in 4m 24s
✔️ build-ansible-collection SUCCESS in 5m 20s

softwarefactory-project-zuul · 2024-12-16T13:45:44Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a92cf4e0c7254da0b954780f275c9869

✔️ ansible-galaxy-importer SUCCESS in 4m 35s
✔️ build-ansible-collection SUCCESS in 5m 18s

softwarefactory-project-zuul · 2024-12-16T14:07:03Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/70b4b5a56895485986dbfd5a1980b85e

✔️ ansible-galaxy-importer SUCCESS in 5m 06s
✔️ build-ansible-collection SUCCESS in 5m 44s

softwarefactory-project-zuul · 2024-12-16T14:22:45Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fc67de0fd32e44aba03efb06182dec1f

✔️ ansible-galaxy-importer SUCCESS in 4m 25s
✔️ build-ansible-collection SUCCESS in 5m 17s

softwarefactory-project-zuul · 2024-12-16T14:41:00Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b10f3d19e62c44ad9c9fa8ea9512c0b8

✔️ ansible-galaxy-importer SUCCESS in 4m 11s
✔️ build-ansible-collection SUCCESS in 5m 23s

softwarefactory-project-zuul · 2024-12-16T15:26:51Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3735d19baf964959a3801b2d3125b92f

✔️ ansible-galaxy-importer SUCCESS in 4m 33s
✔️ build-ansible-collection SUCCESS in 5m 18s

softwarefactory-project-zuul · 2024-12-16T15:50:32Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/38ecc02aff45442fa1340ded9b5f5438

✔️ ansible-galaxy-importer SUCCESS in 2m 50s
✔️ build-ansible-collection SUCCESS in 5m 16s

softwarefactory-project-zuul · 2024-12-16T17:11:50Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fa038cfba0ac4adbbdd501eb9505f915

✔️ ansible-galaxy-importer SUCCESS in 2m 56s
✔️ build-ansible-collection SUCCESS in 5m 46s

yurnov

LGTM

softwarefactory-project-zuul · 2024-12-17T10:18:16Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/3aa3d1ece82c42b3be1e04afc3f52943

✔️ ansible-galaxy-importer SUCCESS in 4m 36s
✔️ build-ansible-collection SUCCESS in 5m 29s

patchback · 2024-12-17T10:18:21Z

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/7559b65946431b246ccfb700141e0143f43086fc/pr-830

Backported as #832

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

SUMMARY Fix charts ref on integration tests targets ISSUE TYPE Bugfix Pull Request Reviewed-by: Yuriy Novostavskiy Reviewed-by: Alina Buzachis (cherry picked from commit 7559b65)

patchback · 2024-12-17T10:18:29Z

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/7559b65946431b246ccfb700141e0143f43086fc/pr-830

Backported as #833

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

SUMMARY Fix charts ref on integration tests targets ISSUE TYPE Bugfix Pull Request Reviewed-by: Yuriy Novostavskiy Reviewed-by: Alina Buzachis (cherry picked from commit 7559b65)

SUMMARY Fix charts ref on integration tests targets ISSUE TYPE Bugfix Pull Request Reviewed-by: Yuriy Novostavskiy Reviewed-by: Alina Buzachis (cherry picked from commit 7559b65) Co-authored-by: Bikouo Aubin <[email protected]>

this commit bring a fix for the integration text merged witin the PR ansible-collections#830

…ollections#830

* new module helm_registry_auth * Initial integration tests * final update copyright and integration test before pr * update link to pr in changelog fragment * reformat plugins/module_utils/helm.py with black to fix linters in actions * attempt to fix unit test unit test was missing initially * fix https://pycqa.github.io/isort/ linter * next attemp to fix unit-test * remove unused and unsupported helm_args_common * remove unused imports and fix other linters errors * another fix for unit test * fix issue introducied by commit ff02893 * add binary_path to arg_spec * return helm_cmd in the output of check mode remove changlog fragment * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * remove changed from module return Co-authored-by: Bikouo Aubin <[email protected]> * remove redundant code Co-authored-by: Bikouo Aubin <[email protected]> * Update plugins/modules/helm_registry_auth.py Co-authored-by: Bikouo Aubin <[email protected]> * consider support of logout when user is not logged in Co-authored-by: Bikouo Aubin <[email protected]> * consider support helm < 3.0.0 * Revert "consider support helm < 3.0.0" This reverts commit f20004d. * reintroduce support of helm version less than 3.8.0 reference: https://helm.sh/docs/topics/registries/#enabling-oci-support-prior-to-v380 * revert reintroducing support of helm < 3.8.0 reason: didn't find a quick way to deal with tests * update documentation with the recent module updates * Update plugins/modules/helm_registry_auth.py Co-authored-by: Bikouo Aubin <[email protected]> * add test of logout impendency Co-authored-by: Bikouo Aubin <[email protected]> * fix linters * fix intendations in the integration tests * create tests/integration/targets/helm_registry_auth/aliases * fix integration test (typo) * fix integration tests (test wrong cred) * add stderr when module fail * another attempt to fix integration test * fix assertion in integration test to be not affceted by the #830 --------- Co-authored-by: Bikouo Aubin <[email protected]>

* new module helm_registry_auth * Initial integration tests * final update copyright and integration test before pr * update link to pr in changelog fragment * reformat plugins/module_utils/helm.py with black to fix linters in actions * attempt to fix unit test unit test was missing initially * fix https://pycqa.github.io/isort/ linter * next attemp to fix unit-test * remove unused and unsupported helm_args_common * remove unused imports and fix other linters errors * another fix for unit test * fix issue introducied by commit ff02893 * add binary_path to arg_spec * return helm_cmd in the output of check mode remove changlog fragment * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * remove changed from module return Co-authored-by: Bikouo Aubin <[email protected]> * remove redundant code Co-authored-by: Bikouo Aubin <[email protected]> * Update plugins/modules/helm_registry_auth.py Co-authored-by: Bikouo Aubin <[email protected]> * consider support of logout when user is not logged in Co-authored-by: Bikouo Aubin <[email protected]> * consider support helm < 3.0.0 * Revert "consider support helm < 3.0.0" This reverts commit f20004d. * reintroduce support of helm version less than 3.8.0 reference: https://helm.sh/docs/topics/registries/#enabling-oci-support-prior-to-v380 * revert reintroducing support of helm < 3.8.0 reason: didn't find a quick way to deal with tests * update documentation with the recent module updates * Update plugins/modules/helm_registry_auth.py Co-authored-by: Bikouo Aubin <[email protected]> * add test of logout impendency Co-authored-by: Bikouo Aubin <[email protected]> * fix linters * fix intendations in the integration tests * create tests/integration/targets/helm_registry_auth/aliases * fix integration test (typo) * fix integration tests (test wrong cred) * add stderr when module fail * another attempt to fix integration test * fix assertion in integration test to be not affceted by the #830 --------- Co-authored-by: Bikouo Aubin <[email protected]> (cherry picked from commit aee8474)

* new module helm_registry_auth * Initial integration tests * final update copyright and integration test before pr * update link to pr in changelog fragment * reformat plugins/module_utils/helm.py with black to fix linters in actions * attempt to fix unit test unit test was missing initially * fix https://pycqa.github.io/isort/ linter * next attemp to fix unit-test * remove unused and unsupported helm_args_common * remove unused imports and fix other linters errors * another fix for unit test * fix issue introducied by commit ff02893 * add binary_path to arg_spec * return helm_cmd in the output of check mode remove changlog fragment * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * remove changed from module return Co-authored-by: Bikouo Aubin <[email protected]> * remove redundant code Co-authored-by: Bikouo Aubin <[email protected]> * Update plugins/modules/helm_registry_auth.py Co-authored-by: Bikouo Aubin <[email protected]> * consider support of logout when user is not logged in Co-authored-by: Bikouo Aubin <[email protected]> * consider support helm < 3.0.0 * Revert "consider support helm < 3.0.0" This reverts commit f20004d. * reintroduce support of helm version less than 3.8.0 reference: https://helm.sh/docs/topics/registries/#enabling-oci-support-prior-to-v380 * revert reintroducing support of helm < 3.8.0 reason: didn't find a quick way to deal with tests * update documentation with the recent module updates * Update plugins/modules/helm_registry_auth.py Co-authored-by: Bikouo Aubin <[email protected]> * add test of logout impendency Co-authored-by: Bikouo Aubin <[email protected]> * fix linters * fix intendations in the integration tests * create tests/integration/targets/helm_registry_auth/aliases * fix integration test (typo) * fix integration tests (test wrong cred) * add stderr when module fail * another attempt to fix integration test * fix assertion in integration test to be not affceted by the #830 --------- Co-authored-by: Bikouo Aubin <[email protected]> (cherry picked from commit aee8474) Co-authored-by: Yuriy Novostavskiy <[email protected]>

SUMMARY Fix charts ref on integration tests targets ISSUE TYPE Bugfix Pull Request Reviewed-by: Yuriy Novostavskiy Reviewed-by: Alina Buzachis

abikouo added the skip-changelog label Dec 16, 2024

yurnov reviewed Dec 16, 2024

View reviewed changes

Fix helm tests

395d62c

abikouo force-pushed the integration_20241216 branch from b5dd3cb to 395d62c Compare December 16, 2024 16:53

abikouo added the test-all-the-targets In order to tell to the integration test splitter to test all targets label Dec 16, 2024

abikouo added 2 commits December 16, 2024 17:55

Remove comment on helm module

bde86ce

Sanity 2.16

ccc1d10

yurnov approved these changes Dec 16, 2024

View reviewed changes

alinabuzachis approved these changes Dec 17, 2024

View reviewed changes

abikouo added backport-3 backport-5 mergeit labels Dec 17, 2024

softwarefactory-project-zuul bot merged commit 7559b65 into ansible-collections:main Dec 17, 2024
110 checks passed

patchback bot mentioned this pull request Dec 17, 2024

[PR #830/7559b659 backport][stable-3] Fix helm integration tests #832

Open

patchback bot mentioned this pull request Dec 17, 2024

[PR #830/7559b659 backport][stable-5] Fix helm integration tests #833

Merged

yurnov added a commit to yurnov/kubernetes.core that referenced this pull request Dec 17, 2024

Merge remote-tracking branch 'upstream/main' into helm_login

099b57e

this commit bring a fix for the integration text merged witin the PR ansible-collections#830

yurnov added a commit to yurnov/kubernetes.core that referenced this pull request Dec 17, 2024

fix assertion in integration test to be not affceted by the ansible-c…

5f48d1b

…ollections#830

yurnov mentioned this pull request Dec 18, 2024

Backport to Stable-3: Fix helm tests (#827) and Fix helm integration tests (#830) #829

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix helm integration tests #830

Fix helm integration tests #830

abikouo commented Dec 16, 2024

yurnov left a comment

softwarefactory-project-zuul bot commented Dec 16, 2024

yurnov commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

yurnov left a comment

softwarefactory-project-zuul bot commented Dec 17, 2024

patchback bot commented Dec 17, 2024 •

edited

Loading

patchback bot commented Dec 17, 2024 •

edited

Loading

Fix helm integration tests #830

Fix helm integration tests #830

Conversation

abikouo commented Dec 16, 2024

SUMMARY

ISSUE TYPE

yurnov left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Dec 16, 2024

yurnov commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

yurnov left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Dec 17, 2024

patchback bot commented Dec 17, 2024 • edited Loading

Backport to stable-3: 💚 backport PR created

patchback bot commented Dec 17, 2024 • edited Loading

Backport to stable-5: 💚 backport PR created

patchback bot commented Dec 17, 2024 •

edited

Loading

patchback bot commented Dec 17, 2024 •

edited

Loading