ansible-lint - Fixing integration tests issues #844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 33s |
yurnov
reviewed
Jan 15, 2025
| path: "~/.kube/config" | ||
| register: _stat | ||
|
|
||
| - name: validate that in-memory kubeconfig authentication failed for kubernetes < 17.17.0 | ||
| - name: Validate that in-memory kubeconfig authentication failed for kubernetes < 17.17.0 |
There was a problem hiding this comment.
I think that this part can be removed as 17.7.0 is released almost 4 years ago https://github.com/kubernetes-client/python/releases/tag/v17.17.0, moreover, this collection require version >=24.2.0:
grep "kubernetes >=" -r * | grep -v -i changelog
docs/kubernetes.core.k8s_module.rst:- kubernetes >= 24.2.0
docs/kubernetes.core.k8s_cluster_info_module.rst:- kubernetes >= 24.2.0
docs/kubernetes.core.k8s_service_module.rst:- kubernetes >= 24.2.0
docs/kubernetes.core.k8s_lookup.rst:- kubernetes >= 24.2.0
docs/kubernetes.core.k8s_inventory.rst:- kubernetes >= 24.2.0
docs/kubernetes.core.k8s_drain_module.rst:- kubernetes >= 24.2.0
docs/kubernetes.core.k8s_json_patch_module.rst:- kubernetes >= 24.2.0
docs/kubernetes.core.k8s_info_module.rst:- kubernetes >= 24.2.0
docs/kubernetes.core.k8s_taint_module.rst:- kubernetes >= 24.2.0
docs/kubernetes.core.k8s_log_module.rst:- kubernetes >= 24.2.0
docs/kubernetes.core.k8s_scale_module.rst:- kubernetes >= 24.2.0
docs/kubernetes.core.k8s_cp_module.rst:- kubernetes >= 24.2.0
docs/kubernetes.core.k8s_rollback_module.rst:- kubernetes >= 24.2.0
docs/kubernetes.core.k8s_exec_module.rst:- kubernetes >= 24.2.0
plugins/modules/k8s_taint.py: - kubernetes >= 24.2.0
plugins/modules/k8s.py: - This option requires "kubernetes >= 19.15.0".
plugins/modules/k8s.py: - "kubernetes >= 24.2.0"
plugins/modules/k8s_exec.py: - "kubernetes >= 24.2.0"
plugins/modules/k8s_cluster_info.py: - "kubernetes >= 24.2.0"
plugins/modules/k8s_json_patch.py: - "kubernetes >= 24.2.0"
plugins/modules/k8s_scale.py: - "kubernetes >= 24.2.0"
plugins/modules/k8s_info.py: - "kubernetes >= 24.2.0"
plugins/modules/k8s_rollback.py: - "kubernetes >= 24.2.0"
plugins/modules/k8s_drain.py: - kubernetes >= 24.2.0
plugins/modules/k8s_service.py: - kubernetes >= 24.2.0
plugins/modules/k8s_log.py: - "kubernetes >= 24.2.0"
plugins/modules/k8s_cp.py: - "kubernetes >= 24.2.0"
plugins/inventory/k8s.py: - "kubernetes >= 24.2.0"
plugins/lookup/k8s.py: - "kubernetes >= 24.2.0"
tests/integration/targets/k8s_check_mode/defaults/main.yml: - k8s_release: "kubernetes >= 18.20.0"
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 02s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixing ansible-lint issues
ISSUE TYPE