Skip to content

Commit

Permalink
make names more specific
Browse files Browse the repository at this point in the history
  • Loading branch information
mikemorency committed Nov 7, 2024
1 parent be76121 commit 6411e94
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions plugins/modules/content_library_item_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def __get_library_item_ids_by_search_param(self, library_id=None):

return self.library_item_service.list(library_id=library_id)

Check warning on line 189 in plugins/modules/content_library_item_info.py

View check run for this annotation

Codecov / codecov/patch

plugins/modules/content_library_item_info.py#L189

Added line #L189 was not covered by tests

def get_library_item_ids(self):
def get_relevant_library_item_ids_by_params(self):
if ((self.params['library_item_id'] or self.params['library_item_name']) and
(not self.params['library_id'] and not self.params['library_name'])):
# User is searching for a library item in any library, we dont need to specify a
Expand All @@ -204,7 +204,7 @@ def get_library_item_ids(self):

return library_item_ids

Check warning on line 205 in plugins/modules/content_library_item_info.py

View check run for this annotation

Codecov / codecov/patch

plugins/modules/content_library_item_info.py#L205

Added line #L205 was not covered by tests

def get_library_item_info(self, library_item_ids):
def get_relevant_library_item_info(self, library_item_ids):
all_library_items_info = []

Check warning on line 208 in plugins/modules/content_library_item_info.py

View check run for this annotation

Codecov / codecov/patch

plugins/modules/content_library_item_info.py#L208

Added line #L208 was not covered by tests
for library_item_id in library_item_ids:
all_library_items_info.append(self.library_item_service.get(library_item_id).to_dict())

Check warning on line 210 in plugins/modules/content_library_item_info.py

View check run for this annotation

Codecov / codecov/patch

plugins/modules/content_library_item_info.py#L210

Added line #L210 was not covered by tests
Expand All @@ -230,8 +230,8 @@ def main():
)

library_item_info_module = ContentLibaryItemInfo(module)
library_item_ids = library_item_info_module.get_library_item_ids()
library_item_info = library_item_info_module.get_library_item_info(library_item_ids)
library_item_ids = library_item_info_module.get_relevant_library_item_ids_by_params()
library_item_info = library_item_info_module.get_relevant_library_item_info(library_item_ids)
module.exit_json(library_item_info=library_item_info)

Check warning on line 235 in plugins/modules/content_library_item_info.py

View check run for this annotation

Codecov / codecov/patch

plugins/modules/content_library_item_info.py#L232-L235

Added lines #L232 - L235 were not covered by tests


Expand Down

0 comments on commit 6411e94

Please sign in to comment.