Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc improvements #21

Merged
merged 3 commits into from
May 21, 2024
Merged

Doc improvements #21

merged 3 commits into from
May 21, 2024

Conversation

Andersson007
Copy link
Contributor

SUMMARY

Relates to my inclusion review in ansible-collections/ansible-inclusion#75 (comment)

@Andersson007 Andersson007 marked this pull request as draft May 21, 2024 06:35
@Andersson007 Andersson007 marked this pull request as ready for review May 21, 2024 06:39
@Andersson007
Copy link
Contributor Author

I don't think the integration test failing relates to the changes.
If you're gonna support the check_mode in all your modules in future, we could move the attributes to a doc_fragment.
Let me know.
ready_for_review

@machacekondra
Copy link
Collaborator

machacekondra commented May 21, 2024

Thank you for the fixes!

I don't think the integration test failing relates to the changes.

Right, it's not. The problem was introduced yesterday in requests library, we will move it podman.

If you're gonna support the check_mode in all your modules in future, we could move the attributes to a doc_fragment.

Well, we want to. But let's keep it separate for now. Thank you.

@bardielle
Copy link
Collaborator

The CI was fixed in the PR 24

@bardielle bardielle merged commit e526505 into ansible-collections:main May 21, 2024
8 of 9 checks passed
@Andersson007
Copy link
Contributor Author

@bardielle @machacekondra thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants