Change the changelog comment #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardielle
force-pushed
the
fix_changlog_doc
branch
from
40ce916 to
c30cd47
Compare
mikemorency
approved these changes
May 28, 2024
|
@felixfontein do you think we can sign the renaming as a minor - since we deprecated the old module but still not removing it from the collection? |
| - vm_list_group_by_clusters_info - Renaming the module vm_list_group_by_clusters to vm_list_group_by_clusters_info | ||
| since, modules that only gather information are named with suffix `info`. | ||
| minor_changes: | ||
| - vm_list_group_by_clusters_info - Renaming the module ``vm_list_group_by_clusters`` to ``vm_list_group_by_clusters_info`` |
There was a problem hiding this comment.
I think there is deprecated_features for this.
|
I will close this PR and @mikemorency will remove it from the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Changing from major to minor change for the renaming module
ISSUE TYPE