Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vmware.vmware upstream CI #43

Merged

Conversation

shellymiron
Copy link
Collaborator

@shellymiron shellymiron commented Jun 27, 2024

SUMMARY

This is a PR for adding the action to run the integration tests on the eco vcenter installed on our baremetals.
The changes are aligned with the validated content repo, and hold the same structure.
The changes includes additional var sent to the the ansible-playbook command called tiny_prefix -
this was added to be aligned the behaviour of the downstream CI, which runs the tests in parallel and requires this var.

COMPONENT NAME

eco-vcenter-ci.yml

NOTE

The PR tested locally and from my own fork, you can see the successful result here.
We will be able to see the job runs on main only after the PR will be merged.

please review :) @anna-savina @elsapassaro

@elsapassaro
Copy link
Collaborator

The integration test for guest_info module is failing (see here) due to a known bug. Can you check why the pipeline did not fail?

@shellymiron
Copy link
Collaborator Author

shellymiron commented Jun 28, 2024

@elsapassaro ok checkout this one
I added an option to report at the end of the run if there are tests which failed and their names.
the makefile will exit with value 1 and will fail the action if even 1 test failed.
I will do the same for vmware_ops, I think the action there also not failing if a target failed.

maybe worth adding a comment on this test with the link to the bug, i'll add it

@shellymiron shellymiron force-pushed the add_action_eco_vcenter_ci branch 10 times, most recently from aa6e941 to 722a064 Compare June 28, 2024 17:45
@shellymiron shellymiron requested a review from elsapassaro July 1, 2024 08:19
@shellymiron
Copy link
Collaborator Author

@elsapassaro I improved it - check here - wdyt?

@elsapassaro
Copy link
Collaborator

@shellymiron that's great!

@elsapassaro
Copy link
Collaborator

/lgtm

Copy link
Collaborator

@anna-savina anna-savina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shellymiron shellymiron merged commit b4b9afc into ansible-collections:main Jul 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants