-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mm feature/save vm as template #48
Merged
mikemorency
merged 1 commit into
ansible-collections:main
from
mikemorency:mm-feature/save-vm-as-template
Jul 19, 2024
Merged
Mm feature/save vm as template #48
mikemorency
merged 1 commit into
ansible-collections:main
from
mikemorency:mm-feature/save-vm-as-template
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemorency
requested review from
shellymiron,
elsapassaro,
anna-savina,
bardielle and
machacekondra
as code owners
July 10, 2024 16:37
mikemorency
force-pushed
the
mm-feature/save-vm-as-template
branch
2 times, most recently
from
July 10, 2024 17:08
573769b
to
657e958
Compare
shellymiron
reviewed
Jul 11, 2024
tests/integration/targets/vmware_folder_template_from_vm/defaults/main.yml
Outdated
Show resolved
Hide resolved
mikemorency
force-pushed
the
mm-feature/save-vm-as-template
branch
from
July 11, 2024 15:30
17a5775
to
74c78cc
Compare
elsapassaro
reviewed
Jul 12, 2024
mikemorency
force-pushed
the
mm-feature/save-vm-as-template
branch
from
July 12, 2024 14:14
33e471e
to
969915d
Compare
bardielle
reviewed
Jul 15, 2024
bardielle
reviewed
Jul 15, 2024
bardielle
reviewed
Jul 15, 2024
bardielle
reviewed
Jul 15, 2024
bardielle
reviewed
Jul 15, 2024
elsapassaro
reviewed
Jul 16, 2024
tests/integration/targets/vmware_folder_template_from_vm/defaults/main.yml
Outdated
Show resolved
Hide resolved
mikemorency
force-pushed
the
mm-feature/save-vm-as-template
branch
2 times, most recently
from
July 18, 2024 13:31
712c07d
to
c432b67
Compare
mikemorency
force-pushed
the
mm-feature/save-vm-as-template
branch
from
July 18, 2024 14:15
c432b67
to
0b1f33e
Compare
bardielle
approved these changes
Jul 18, 2024
mariolenz
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a mouthful, but LGTM as far as I can see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This module creates a template in a folder from a VM. Its designed to replace some of the functionality in community.vmware.vmware_guest.
The module allows a user to create or delete a template in a folder. If you create a template, you must specify a VM to clone and use as a base for the template. Once the template is created, the user would use another module to modify the configuration (right now I think they would use vmware_guest, but a new module would probably be useful).
This module is similar in functionality to the existing content_template module, which creates/deletes a template in a content library.
ISSUE TYPE
COMPONENT NAME
folder_template_from_vm