Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #68
When setting the DRS vmotion rate, the user input value gets reversed by the vCenter API (so 1 becomes 5 and 5 becomes 1). This is confusing because the UI and documentation do not indicate this in anyway.
This fix makes the module reverse the numbers in code, so if a user chooses a rate of 1, we change it to 5 in code before inputting it in the API. It will display as 1 in the UI which is what the user wanted in the first place.
ISSUE TYPE
COMPONENT NAME
cluster_drs
ADDITIONAL INFORMATION
The
community.vmware.vcenter_cluster_info
module reports back what the API says. This means that if the user sets the DRS rate to 2, the cluster info module will say the DRS rate is 4. Obviously this is confusing, so when the info module is migrated to this repo, we should fix that as well. I left a note in our tests (which use that module) and made a jira ticket to follow up.