-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mm feature/migrate drs recommendations #74
Mm feature/migrate drs recommendations #74
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 26.09% 27.15% +1.05%
==========================================
Files 19 22 +3
Lines 1667 1860 +193
Branches 331 354 +23
==========================================
+ Hits 435 505 +70
- Misses 1232 1355 +123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
According to the actual output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
When applying DRS recommendations, nothing is returned by the ApplyRecommendation method. This change adds a step to lookup the latest task associated with the VM targeted by the recommendation and monitors that task to determine if the recommendation succeeded.
ISSUE TYPE
COMPONENT NAME
cluster_drs_recommendations