Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mm feature/migrate drs recommendations #74

Conversation

mikemorency
Copy link
Collaborator

SUMMARY

When applying DRS recommendations, nothing is returned by the ApplyRecommendation method. This change adds a step to lookup the latest task associated with the VM targeted by the recommendation and monitors that task to determine if the recommendation succeeded.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cluster_drs_recommendations

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.15%. Comparing base (013afa4) to head (2ebbcf7).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/cluster_drs_recommendations.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   26.09%   27.15%   +1.05%     
==========================================
  Files          19       22       +3     
  Lines        1667     1860     +193     
  Branches      331      354      +23     
==========================================
+ Hits          435      505      +70     
- Misses       1232     1355     +123     
Flag Coverage Δ
sanity 27.15% <0.00%> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anna-savina
Copy link
Collaborator

According to the actual output:

            "description": "server1 will move from host1 to host2.",

https://github.com/ansible-collections/vmware.vmware/pull/74/files#diff-885f606d18e22e32b5edc70c8b0050e053d98d58db88c5c6e939383350ac32a2R60

            "description": "server2 will move from host1 to host2.",

https://github.com/ansible-collections/vmware.vmware/pull/74/files#diff-885f606d18e22e32b5edc70c8b0050e053d98d58db88c5c6e939383350ac32a2R70

Copy link
Collaborator

@anna-savina anna-savina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikemorency mikemorency merged commit ccda8a7 into ansible-collections:main Oct 8, 2024
12 of 13 checks passed
@mikemorency mikemorency deleted the mm-feature/migrate-drs-recommendations branch October 8, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants