-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/standardize pyvmomi method names #88
Merged
mikemorency
merged 4 commits into
ansible-collections:main
from
mikemorency:feature/standardize-pyvmomi-method-names
Dec 16, 2024
Merged
Feature/standardize pyvmomi method names #88
mikemorency
merged 4 commits into
ansible-collections:main
from
mikemorency:feature/standardize-pyvmomi-method-names
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 27.48% 27.40% -0.08%
==========================================
Files 24 24
Lines 2059 2065 +6
Branches 385 387 +2
==========================================
Hits 566 566
- Misses 1493 1499 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mikemorency
requested review from
shellymiron,
elsapassaro,
anna-savina,
bardielle and
machacekondra
as code owners
December 11, 2024 02:43
anna-savina
reviewed
Dec 11, 2024
anna-savina
reviewed
Dec 11, 2024
anna-savina
reviewed
Dec 11, 2024
anna-savina
reviewed
Dec 11, 2024
machacekondra
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is preparing the pymomi module utils to be made public. There are two main changes in this PR, all relating to module_utils/_vmware
Standardize the get__by_name_or_moid methods. These methods are all very similar but some slightly differ just because they were written at different times. This change updates the names to be both descriptive and similar to one another, updates documentation for the methods to be similar to one another, and adds an optional parameter to throw a standard error if the search comes back empty
list_all_objs_by_type
doesnt match the get_ method name pattern we have and needlessly return a dict. Updated the name to beget_all....
and changed the return value to a list, like the other methodsThere should be no change in functionality.
I am not able to update the rest utils yet. I think i see some possible bugs with the current methods and I want to confirm and fix those first
ISSUE TYPE
COMPONENT NAME
module_utils/_vmware