-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate argument specs and doc fragments #89
consolidate argument specs and doc fragments #89
Conversation
9d32d91
to
6a60822
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 27.48% 27.97% +0.48%
==========================================
Files 24 25 +1
Lines 2059 2073 +14
Branches 385 384 -1
==========================================
+ Hits 566 580 +14
Misses 1493 1493
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikemorency I'd like to test your changes with community.vmware
. That is, what would happen if I try to (re-) use them there.
Please give me a few days for this.
Sure thing @mariolenz, I appreciate the additional testing. If possible, I'd like to merge by the 18th so we can do some additional QA before the targeted release on the 23rd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikemorency Apart from my last comment above LGTM
SUMMARY
Combining #86 and #87
This removes instances of repeated option documentation and redundant spec args.
ISSUE TYPE
COMPONENT NAME
doc fragments
argument specs
ADDITIONAL INFORMATION
While I was working on this, I found the kubernetes collection has a pretty nice pattern for breaking out the doc fragments. I tried to copy theirs, https://github.com/ansible-collections/kubernetes.core/tree/main/plugins/doc_fragments
Similar pattern for the arg specs too https://github.com/ansible-collections/kubernetes.core/blob/main/plugins/module_utils/args_common.py