-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm_name now not a required variable #93
vm_name now not a required variable #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vm_name
is still required when state==present. The module needs to check for that, preferably in the argument spec definition. And the docs need to reflect that
re-base branch please. Your branch doesn't include changes from 92 |
6df4796
to
0a698a7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 27.38% 27.38%
=======================================
Files 31 31
Lines 2542 2542
Branches 468 468
=======================================
Hits 696 696
Misses 1846 1846
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Remove |
7a4e2c7
to
0179fe2
Compare
SUMMARY
Fixes: vm_name now not a required variable
ISSUE TYPE
COMPONENT NAME
content_template module