Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm_name now not a required variable #93

Merged
merged 7 commits into from
Jan 5, 2025

Conversation

OrrBG
Copy link
Contributor

@OrrBG OrrBG commented Dec 23, 2024

SUMMARY

Fixes: vm_name now not a required variable

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

content_template module

Copy link
Collaborator

@mikemorency mikemorency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vm_name is still required when state==present. The module needs to check for that, preferably in the argument spec definition. And the docs need to reflect that

@anna-savina
Copy link
Collaborator

anna-savina commented Dec 24, 2024

re-base branch please. Your branch doesn't include changes from 92

@OrrBG OrrBG force-pushed the bugfix/vm_name-required branch from 6df4796 to 0a698a7 Compare December 26, 2024 07:04
@mikemorency mikemorency self-requested a review December 31, 2024 15:18
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.38%. Comparing base (1066489) to head (0179fe2).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   27.38%   27.38%           
=======================================
  Files          31       31           
  Lines        2542     2542           
  Branches      468      468           
=======================================
  Hits          696      696           
  Misses       1846     1846           
Flag Coverage Δ
sanity 27.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anna-savina
Copy link
Collaborator

@OrrBG OrrBG force-pushed the bugfix/vm_name-required branch from 7a4e2c7 to 0179fe2 Compare January 5, 2025 13:17
@anna-savina anna-savina merged commit f83e45c into ansible-collections:main Jan 5, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants