Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/migrate esxi maintenance mode #99

Conversation

mikemorency
Copy link
Collaborator

SUMMARY

Migrating the community.vmware.vmware_maintenancemode module to here.
The functionality is the same, although one or two input options have been renamed for clarity

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

esxi_maintenance_mode

@mikemorency
Copy link
Collaborator Author

mikemorency commented Jan 8, 2025

i am not sure why that test is failing. it looks like an unrelated error. ill re-run it later

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 33.80282% with 47 lines in your changes missing coverage. Please review.

Project coverage is 28.39%. Comparing base (b50c216) to head (2ac0c58).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/esxi_maintenance_mode.py 34.84% 43 Missing ⚠️
plugins/module_utils/_module_pyvmomi_base.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   28.04%   28.39%   +0.35%     
==========================================
  Files          31       33       +2     
  Lines        2350     2511     +161     
  Branches      426      453      +27     
==========================================
+ Hits          659      713      +54     
- Misses       1691     1798     +107     
Flag Coverage Δ
sanity 28.39% <33.80%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemorency mikemorency force-pushed the feature/migrate-esxi-maintenance-mode branch from 6e56757 to 2ac0c58 Compare January 14, 2025 15:36
@mikemorency mikemorency merged commit cebef3b into ansible-collections:main Jan 15, 2025
13 checks passed
@mikemorency mikemorency deleted the feature/migrate-esxi-maintenance-mode branch January 15, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants