Adding support for JWT auth to vault #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netdata-be
force-pushed
the
support_identit_for_vault
branch
from
928dbec
to
bbfaabe
Compare
In newer versions of nomad you get this warning: ``` agent: Setting a Vault token in the agent configuration is deprecated and will be removed in Nomad 1.9. Migrate your Vault configuration to use workload identity. ``` This PR adds a default idenity section the config if set, so that we don't break older nomad versions.
netdata-be
force-pushed
the
support_identit_for_vault
branch
from
bbfaabe
to
329e01a
Compare
|
LGTM! Are these two options mutually exclusive? If yes, should we accomodate for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In newer versions of nomad you get this warning:
This PR adds a default idenity section the config if set, so that we don't break older nomad versions.