Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: bug fixes #195

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Fix: bug fixes #195

merged 2 commits into from
Apr 5, 2024

Conversation

teliov
Copy link
Contributor

@teliov teliov commented Mar 31, 2024 •
edited
Loading

  • Fix: do not use nomad_user/nomad_group when a task is delegated to local host
    Using the nomad_user/nomad_group when task is delegated to localhost (i.e the control machine) only works if the user/group exists and has access to the directory/files specified.
  • Fix gossip key generation for nomad versions >= 1.4.0

@teliov teliov changed the title Fix: do not use nomad_user/nomad_group when a task is delegated to local host Fix: bug fixes Mar 31, 2024
@rndmh3ro rndmh3ro requested a review from beechesII April 2, 2024 11:59
@Rendanic
Copy link
Contributor

Rendanic commented Apr 3, 2024

The fix for nomad_user/nomad_group works perfect on my side.

beechesII
beechesII approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@beechesII beechesII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@beechesII beechesII merged commit 81192bb into ansible-community:master Apr 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beechesII beechesII beechesII approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teliov @Rendanic @beechesII