-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates post vmware_rest release 4.0.0 #89
base: main
Are you sure you want to change the base?
updates post vmware_rest release 4.0.0 #89
Conversation
8a01a23
to
e7781c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ATM I don't feel able to approve this because I'm not 100% sure that I understand the changes.
But maybe @anna-savina, @mikemorency, @prabinovRedhat or @shellymiron have something to say about this. They've contributed to vmware.vmware_rest
recently and, at the end of the day, the idea is to generate this collection and not do manual changes. So maybe they have some useful insights or comments on this.
its been awhile, but heres the reason for different changes:
|
SUMMARY
These are changes I had to make to succesfully generate content in vmware.vmware_rest release 4.0.0. It included a new openapi spec, which introduced some new data types (corresponding to existing or new modules).
Additionally, i had to update the asyncio initialization for python 3.12. The previous was of getting a loop has been deprecated. The method included in this PR passed python 3.8 + sanity checks
ISSUE TYPE
COMPONENT NAME
generate_cloud_modules
vmware_rest
ADDITIONAL INFORMATION
Related: ansible-collections/vmware.vmware_rest#511