add verify-upstreams and sanity-tests subcommands
#556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
gotmax23
force-pushed
the
verify-upstream
branch
2 times, most recently
from
eb6bab1 to
8625570
Compare
gotmax23
changed the title
verify-upstreams and sanity-tests subcommands
gotmax23
force-pushed
the
verify-upstream
branch
3 times, most recently
from
e75736a to
9a843f4
Compare
gotmax23
force-pushed
the
verify-upstream
branch
3 times, most recently
from
3a5dbaa to
3b411a7
Compare
gotmax23
force-pushed
the
verify-upstream
branch
from
88c0ef0 to
d070c3f
Compare
gotmax23
force-pushed
the
verify-upstream
branch
2 times, most recently
from
959885f to
c9a9b8c
Compare
gotmax23
changed the title
verify-upstreams and sanity-tests subcommandsverify-upstreams and sanity-tests subcommands
gotmax23
force-pushed
the
verify-upstream
branch
2 times, most recently
from
267a31f to
cc3a7fd
Compare
gotmax23
force-pushed
the
verify-upstream
branch
from
cc3a7fd to
e1b8328
Compare
felixfontein
approved these changes
Jan 21, 2024
gotmax23
force-pushed
the
verify-upstream
branch
2 times, most recently
from
3b5fdf8 to
bb35c47
Compare
|
Restarting CI |
We can use a TypedDict to provide more structured type checking for the tag data dictionary.
Add a `verify-upstreams` subcommand to ensure that files in a collection's Galaxy collection artifact (roughly) match the contents of its upstream repository. This will help enforce the Repository Management policies in the Collection Requirements.
Some collections have symlinks like `playbooks/ansible_collections/NAMESPACE/NAME -> ../../../` or `README.md -> ../README.md` (in a repository where the collection is in a subdirectory) that require special handling. We want to preserve symlinks unless they point to a file from outside the collection directory.
gotmax23
force-pushed
the
verify-upstream
branch
from
bb35c47 to
243845b
Compare
|
Thanks, @felixfontein, for the review and detailed feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results: https://github.com/ansible-community/package-test-results
Relates: #321