Fix references in regex replace #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @draygoX Great fixes in the PR and would be happy to merge, unfortunately the git commits are not signed or gpg signed. These are two requirements for the PR to be accepted. many thanks uk-bolly |
uk-bolly
added a commit
that referenced
this pull request
Sep 16, 2024
Signed-off-by: Mark Bolwell <[email protected]>
Merged
|
hi @draygoX Thank you for the PR, i have managed to incorporate your fixes into the latest devel updates. I have given credit as this is a great catch. many thanks uk-bolly |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
fix references in regex replace for 4.4.3.x section. Other option would be to fix the OR sections by adding ?: to the start so they are no longer references.
Issue Fixes:
/issues/375
Enhancements:
Please list any enhancements/features that are not open issue tickets
How has this been tested?:
N/A