RHEL-09-251040: Resolve iteration issue

[fallenpixel]

Overall Review of Changes:
Loop over each task in this block, that way item is defined. Correct the boolean logic for warning/logging for interfaces. Warnings should be issued if an interface in ansible_facts.interfaces is allowed in promiscuous mode.
Issue Fixes:
Please list (using linking) any open issues this PR addresses
#1
Enhancements:
Please list any enhancements/features that are not open issue tickets

How has this been tested?:
Tested on fresh install of RHEL 9.3 via the network boot iso.

This is a resubmit, going into devel.

[uk-bolly]

hi @fallenpixel

Thank you for the updating, I am currently trying to replicate why we are seeing a failure in the workflow, happy to get this merged as soon as that is resolved.

thanks

uk-bolly

[fallenpixel]

Do we want to check for the existence of kdump.service, or only run that task if /usr/share/systemd/system/kdump.service is present on the system? I can add an commit for that as well.

[fallenpixel]

- name: "MEDIUM | RHEL-09-213115 | PATCH | The kdump service on RHEL 9 must be disabled."
  when:
    - rhel_09_213115
    - "'kdump' in ansible_facts.packages"
  tags:
    - RHEL-09-213115
    - CAT2
    - CCI-000366
    - SRG-OS-000480-GPOS-00227
    - SV-257818r925441_rule
    - V-257818
    - NIST800-53R4_CM-6
  ansible.builtin.systemd:
    daemon_reload: true
    enabled: false
    masked: true
    name: kdump
    state: stopped

Something like this would stop the current error in the workflow. Should I add to this PR?

[uk-bolly]

- name: "MEDIUM | RHEL-09-213115 | PATCH | The kdump service on RHEL 9 must be disabled."
  when:
    - rhel_09_213115
    - "'kdump' in ansible_facts.packages"
  tags:
    - RHEL-09-213115
    - CAT2
    - CCI-000366
    - SRG-OS-000480-GPOS-00227
    - SV-257818r925441_rule
    - V-257818
    - NIST800-53R4_CM-6
  ansible.builtin.systemd:
    daemon_reload: true
    enabled: false
    masked: true
    name: kdump
    state: stopped

Something like this would stop the current error in the workflow. Should I add to this PR?

Spot on

Im just creating a new PR to ensure all is tested all the way through again. Not sure why this has changed but im working through the issues now.
Happy for you to take the info and add to your PR once we have this sorted.

Thanks

uk-bolly

[uk-bolly]

- name: "MEDIUM | RHEL-09-213115 | PATCH | The kdump service on RHEL 9 must be disabled."
  when:
    - rhel_09_213115
    - "'kdump' in ansible_facts.packages"
  tags:
    - RHEL-09-213115
    - CAT2
    - CCI-000366
    - SRG-OS-000480-GPOS-00227
    - SV-257818r925441_rule
    - V-257818
    - NIST800-53R4_CM-6
  ansible.builtin.systemd:
    daemon_reload: true
    enabled: false
    masked: true
    name: kdump
    state: stopped

Something like this would stop the current error in the workflow. Should I add to this PR?

Spot on

Im just creating a new PR to ensure all is tested all the way through again. Not sure why this has changed but im working through the issues now. Happy for you to take the info and add to your PR once we have this sorted.

Thanks

uk-bolly

hi @fallenpixel

Have managed to work through it all, why this is has become an issue i'm not sure. There is another PR that has just passed that has all the changes i've made within.
There was also other changes in the IaC code required which i have also carried out.
Happy for you to take the changes if you like into this PR.

Many thanks for your time and patience.

uk-bolly

[fallenpixel]

Not overly worried about it. If you've got a branch with this fix, them I'm good closing. Ty for your work.