Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing AWS from the collection and making it general #8

Conversation

RanabirChakraborty
Copy link
Member

Removing AWS from the collection and making it general

Copy link
Member

@guidograzioli guidograzioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comment; while you are here, can you also get rid of the "promtail" role and tasks?

README.md Show resolved Hide resolved
galaxy.yml Outdated Show resolved Hide resolved
inventory/group_vars/eu_central_1.yml Outdated Show resolved Hide resolved
@RanabirChakraborty
Copy link
Member Author

@guidograzioli review now.

@guidograzioli guidograzioli self-requested a review October 30, 2024 16:31
Copy link
Member

@guidograzioli guidograzioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidograzioli guidograzioli merged commit 686bb6a into ansible-middleware:main Oct 30, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants