Clean up assigned but now used flak8 errors

Signed-off-by: Paul Belanger <[email protected]>
ansible-network · Dec 17, 2018 · 544429c · 544429c
1 parent 851ad4e
commit 544429c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 12 deletions.
diff --git a/action_plugins/extract_banners.py b/action_plugins/extract_banners.py
@@ -84,7 +84,6 @@ def run(self, tmp=None, task_vars=None):
         return result
 
     def _extract_banners(self, config):
-        banners = {}
         config_lines = config.split('\n')
         found_banner_start = 0
         banner_meta = []
@@ -97,7 +96,7 @@ def _extract_banners(self, config):
                         banner_delimiter = banner_start.group(2)
                         banner_delimiter = banner_delimiter.strip()
                         banner_delimiter_esc = re.escape(banner_delimiter)
-                    except Exception as e:
+                    except Exception:
                         continue
                     banner_start_index = linenum
                     found_banner_start = 1

diff --git a/action_plugins/parse_validate_acl.py b/action_plugins/parse_validate_acl.py
@@ -43,8 +43,6 @@
 class ActionModule(ActionBase):
 
     def run(self, tmp=None, task_vars=None):
-        socket_path = None
-
         result = super(ActionModule, self).run(task_vars=task_vars)
 
         try:
@@ -88,7 +86,7 @@ def run(self, tmp=None, task_vars=None):
 
     def _create_packet_dict(self, cmd_out):
         import warnings
-        with warnings.catch_warnings(record=True) as w:
+        with warnings.catch_warnings(record=True):
             warnings.simplefilter("always")
             from trigger.acl import parse
         import netaddr
@@ -103,7 +101,7 @@ def _create_packet_dict(self, cmd_out):
             pd_it = {}
             try:
                 p = parse(line)
-            except Exception as e:
+            except Exception:
                 continue
 
             if p.terms:

diff --git a/action_plugins/verify_dependent_role_version.py b/action_plugins/verify_dependent_role_version.py
@@ -51,9 +51,6 @@ def run(self, tmp=None, task_vars=None):
         except KeyError as exc:
             return {'failed': True, 'msg': 'missing required argument: %s' % exc}
 
-        # Get max version if specified
-        max_version = self._task.args.get('max_version')
-
         # Get dependancy version dict if not encoded in meta
         depends_dict = self._task.args.get('depends_map')
 
@@ -96,7 +93,7 @@ def _get_role_dependencies(self, role_path):
                 f = open(meta_path, 'r')
                 metadata = yaml.safe_load(f)
                 role_dependencies = metadata.get('dependencies') or []
-            except (OSError, IOError) as IOe:
+            except (OSError, IOError):
                 display.vvv("Unable to load metadata for %s" % role_path)
                 return False
             finally:
@@ -186,7 +183,7 @@ def _get_role_version(self, role_path):
             try:
                 f = open(info_path, 'r')
                 install_info = yaml.safe_load(f)
-            except (OSError, IOError) as IOe:
+            except (OSError, IOError):
                 display.vvv(
                     "Unable to load galaxy install info for %s" % role_path)
                 return "unknown"

diff --git a/tox.ini b/tox.ini
@@ -19,7 +19,7 @@ commands = {posargs}
 [flake8]
 # TODO(pabelanger): Follow sane flake8 rules for galaxy and sync across all of
 # ansible-network.
-ignore = E125,E402,F401,F841
+ignore = E125,E402,F401
 max-line-length = 160
 show-source = True
 exclude = .tox,dist,build,*.egg