evpn esi multihome model #301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalabi1
suggested changes
Apr 22, 2025
| 'supported_by': 'community' | ||
| } | ||
| NETWORK_OS: sonic | ||
| RESOURCE: snmp |
There was a problem hiding this comment.
Suggested change
| RESOURCE: snmp | |
| RESOURCE: evpn_esi_multihome |
| COPYRIGHT: Copyright 2025 Dell Inc. or its subsidiaries. All Rights Reserved. | ||
| DOCUMENTATION: | | ||
| module: sonic_evpn_esi_multihome | ||
| version_added: 4.5 |
There was a problem hiding this comment.
Suggested change
| version_added: 4.5 | |
| version_added: 3.1.0 |
| DOCUMENTATION: | | ||
| module: sonic_evpn_esi_multihome | ||
| version_added: 4.5 | ||
| short_description: Manage SNMP configuration on SONiC |
There was a problem hiding this comment.
Suggested change
| short_description: Manage SNMP configuration on SONiC | |
| short_description: Manage EVPN ESI multihoming configuration on SONiC |
| version_added: 4.5 | ||
| short_description: Manage SNMP configuration on SONiC | ||
| description: | ||
| - This module provides configuration management of SNMP for devices running SONiC |
There was a problem hiding this comment.
Suggested change
| - This module provides configuration management of SNMP for devices running SONiC | |
| - This module provides configuration management of EVPN ESI multihoming for devices running SONiC |
| options: | ||
| config: | ||
| description: | ||
| - evpn esi multihome configuration |
There was a problem hiding this comment.
Suggested change
| - evpn esi multihome configuration | |
| - EVPN ESI multihoming configuration |
| - evpn esi multihome configuration | ||
| type: dict | ||
| suboptions: | ||
| mac-holdtime: |
There was a problem hiding this comment.
Suggested change
| mac-holdtime: | |
| mac_holdtime: |
attribute names should use underscores and not hyphens
| suboptions: | ||
| mac-holdtime: | ||
| description: | ||
| - mac holdtime |
There was a problem hiding this comment.
Suggested change
| - mac holdtime | |
| - MAC hold time in seconds, range 0-86400 |
| type: int | ||
| neigh-holdtime: | ||
| description: | ||
| - neigh holdtime |
There was a problem hiding this comment.
Suggested change
| - neigh holdtime | |
| - Neighbor hold time in seconds |
| type: int | ||
| startup-delay: | ||
| description: | ||
| - startup delay |
There was a problem hiding this comment.
Suggested change
| - startup delay | |
| - Startup delay in seconds |
There was a problem hiding this comment.
Please add df_election_time and es_activation_delay as they are supported in CLI. Also, please add ranges for all attributes of type int.
stalabi1
reviewed
Apr 22, 2025
| # show running-configuration evpn-mh | ||
| # | ||
| # evpn esi-multihoming | ||
| # mac-holdtime 1080 |
There was a problem hiding this comment.
Suggested change
| # mac-holdtime 1080 |
stalabi1
reviewed
Apr 22, 2025
| # | ||
| # evpn esi-multihoming | ||
| # mac-holdtime 1080 | ||
| # neigh-holdtime 1080 |
There was a problem hiding this comment.
Suggested change
| # neigh-holdtime 1080 |
Replaced state should replace the entire existing config dictionary with the new config dictionary specified in the playbook.
stalabi1
approved these changes
Apr 22, 2025
stalabi1
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.