Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCA: add playbook explanation and generation end-points #1055

Conversation

goneri
Copy link
Contributor

@goneri goneri commented May 23, 2024

@goneri goneri force-pushed the goneri/WCA-add-playbook-explanation-and-generation-end-points_14739 branch from 10f8421 to db2cc64 Compare May 27, 2024 17:38
- Add the new endpoints
- Add a `request` parameter to `generate_playbook()` and `explain_playbook()`. We need
  it to get the user `organization_id`.
@goneri goneri force-pushed the goneri/WCA-add-playbook-explanation-and-generation-end-points_14739 branch from db2cc64 to baa0e90 Compare May 27, 2024 21:48
@goneri goneri requested a review from TamiTakamiya May 27, 2024 21:49
@goneri goneri requested a review from manstis May 28, 2024 13:32
Copy link
Contributor

@TamiTakamiya TamiTakamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too 👍

@goneri goneri merged commit e2d8e12 into main May 28, 2024
9 checks passed
@goneri goneri deleted the goneri/WCA-add-playbook-explanation-and-generation-end-points_14739 branch May 28, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants