Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the .yaml file extension on the default EE file #631

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Allow the .yaml file extension on the default EE file #631

merged 2 commits into from
Nov 27, 2023

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented Nov 10, 2023 •
edited
Loading

Allows the .yaml file extension on the default EE filename for use with the ansible-builder CLI command.

This also allows for use of the new extension for a collection meta EE file.

Fixes #619

@github-actions github-actions bot added docs Changes to documentation needs_triage New item that needs to be triaged labels Nov 10, 2023
@Shrews Shrews force-pushed the issue619 branch 4 times, most recently from 792a2aa to 84fd48e Compare November 10, 2023 20:51
@Shrews Shrews marked this pull request as ready for review November 10, 2023 21:04
@Shrews Shrews requested a review from a team as a code owner November 10, 2023 21:04
@Shrews Shrews changed the title Allow all valid YAML file extensions Allow the .yaml file extension on the default EE file Nov 10, 2023
@Shrews Shrews marked this pull request as draft November 10, 2023 21:25
@Shrews Shrews marked this pull request as ready for review November 13, 2023 20:07
Akasurde
Akasurde approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/ansible_builder/cli.py Outdated Show resolved Hide resolved
@Akasurde Akasurde removed the needs_triage New item that needs to be triaged label Nov 15, 2023
@Shrews Shrews merged commit 8125210 into ansible:devel Nov 27, 2023
13 checks passed
@Shrews Shrews deleted the issue619 branch November 27, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
docs Changes to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request]: add execution-environment.yaml to file lookup during the build
2 participants
@Shrews @Akasurde