Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note explaining injected task has always tag #1119

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

tomkivlin
Copy link
Contributor

@tomkivlin tomkivlin commented Feb 12, 2024

Resolves ansible/ansible#82670

Signed-off-by: Tom Kivlin [email protected]

@ansible-documentation-bot ansible-documentation-bot bot added the new_contributor This PR is the first contribution by a new community member. label Feb 12, 2024
@ansible-documentation-bot
Copy link
Contributor

Thanks for your Ansible docs contribution! We talk about Ansible documentation on matrix at #docs:ansible.im and on libera IRC at #ansible-docs if you ever want to join us and chat about the docs! We meet there on Tuesdays (see the Ansible calendar) and welcome additions to our weekly agenda items - scroll down to find the upcoming agenda and add a comment to put something new on that agenda.

Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left some suggestions that might help with readability / clarity but you can take them or leave them. Thanks for the docs contribution @tomkivlin

docs/docsite/rst/playbook_guide/playbooks_reuse_roles.rst Outdated Show resolved Hide resolved
@tomkivlin
Copy link
Contributor Author

LGTM. I left some suggestions that might help with readability / clarity but you can take them or leave them. Thanks for the docs contribution @tomkivlin

Many thanks - I've accepted them 👍🏻

@oraNod oraNod added backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.16 Automatically create a backport for the stable-2.16 branch labels Feb 21, 2024
@oraNod oraNod merged commit 10fcdc0 into ansible:devel Feb 21, 2024
8 checks passed
Copy link

patchback bot commented Feb 21, 2024

Backport to stable-2.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.15/10fcdc09450a6da86610776429ce15e90ca1f2fa/pr-1119

Backported as #1146

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 21, 2024
Add note explaining injected task has always tag

(cherry picked from commit 10fcdc0)
Copy link

patchback bot commented Feb 21, 2024

Backport to stable-2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.16/10fcdc09450a6da86610776429ce15e90ca1f2fa/pr-1119

Backported as #1147

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 21, 2024
Add note explaining injected task has always tag

(cherry picked from commit 10fcdc0)
oraNod added a commit that referenced this pull request Feb 21, 2024
…/10fcdc09450a6da86610776429ce15e90ca1f2fa/pr-1119

[PR #1119/10fcdc09 backport][stable-2.15] Add note explaining injected task has always tag
oraNod added a commit that referenced this pull request Feb 21, 2024
…/10fcdc09450a6da86610776429ce15e90ca1f2fa/pr-1119

[PR #1119/10fcdc09 backport][stable-2.16] Add note explaining injected task has always tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.16 Automatically create a backport for the stable-2.16 branch new_contributor This PR is the first contribution by a new community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behaviour of "rule argument validation" task when targeting or skipping plays/roles by tags
2 participants