Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flymake-ansible-lint.el to list of tools #2239

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

omsai
Copy link
Contributor

@omsai omsai commented Dec 2, 2024

Using ansible-lint inside of Emacs available using a package from MELPA ansible/ansible-lint#1326

@ansible-documentation-bot ansible-documentation-bot bot added the new_contributor This PR is the first contribution by a new community member. label Dec 2, 2024
@ansible-documentation-bot
Copy link
Contributor

Thanks for your Ansible docs contribution! We talk about Ansible documentation on Matrix at #docs:ansible.im if you ever want to join us and chat about the docs! We meet on Matrix every Tuesday. See the Ansible calendar for meeting details. We welcome additions to our weekly agenda items too. You can add the dawgs-meeting tag to a forum topic to bring it up at the next meeting.

@oraNod oraNod changed the title Fixes ansible/ansible-lint#1326 Add flymake-ansible-lint.el to list of tools Dec 2, 2024
@@ -25,6 +25,7 @@ A free, open-source text editor and IDE that supports auto-indentation, syntax h
* `jinja2-mode <https://github.com/paradoxxxzero/jinja2-mode>`_ - Jinja2 highlighting and syntax checking.
* `magit-mode <https://github.com/magit/magit>`_ - Git porcelain within Emacs.
* `lsp-mode <https://emacs-lsp.github.io/lsp-mode/page/lsp-ansible/>`_ - Ansible syntax highlighting, auto-completion and diagnostics.
* `flymake-ansible-lint <https://github.com/jamescherti/flymake-ansible-lint.el>`_ - Ansible Lint integration with automatic/continuous annotation of errors, warnings, and info while editing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omsai This looks OK to me. Thanks for the contribution. Could you please amend the commit message to something a bit more meaningful than fixes Ansible lint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oraNod Indeed, that was sloppy of me 😅 - is the new commit message okay?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries @omsai that looks good to me now. Thanks again for adding this to the docs.

@oraNod oraNod added backport-2.16 Automatically create a backport for the stable-2.16 branch backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch labels Dec 4, 2024
@samccann samccann merged commit 2cf2053 into ansible:devel Dec 10, 2024
11 checks passed
Copy link

patchback bot commented Dec 10, 2024

Backport to stable-2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.16/2cf205396e4ed0ee7986d462a07ded3ddad6201f/pr-2239

Backported as #2275

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link

patchback bot commented Dec 10, 2024

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/2cf205396e4ed0ee7986d462a07ded3ddad6201f/pr-2239

Backported as #2276

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link

patchback bot commented Dec 10, 2024

Backport to stable-2.18: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.18/2cf205396e4ed0ee7986d462a07ded3ddad6201f/pr-2239

Backported as #2278

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 10, 2024
samccann pushed a commit that referenced this pull request Dec 10, 2024
samccann pushed a commit that referenced this pull request Dec 10, 2024
samccann pushed a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.16 Automatically create a backport for the stable-2.16 branch backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch new_contributor This PR is the first contribution by a new community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants