Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collection_requirements: add meta/execution-environments.yml #871

Merged
merged 4 commits into from
Jan 17, 2024
Merged

collection_requirements: add meta/execution-environments.yml #871

merged 4 commits into from
Jan 17, 2024

Conversation

Andersson007
Copy link
Contributor

@Andersson007 Andersson007 commented Nov 28, 2023 •
edited by gotmax23
Loading

It's not hard to list controller-node requirements in two files but it'd make EE users' life much easier

Discussion: https://forum.ansible.com/t/collection-inclusion-requirements-add-requirements-txt-and-bindep-txt/2611/

@Andersson007 Andersson007 requested a review from a team as a code owner November 28, 2023 10:17
@ansible-documentation-bot ansible-documentation-bot bot added the sc_approval This PR requires approval from the Ansible Community Steering Committee label Nov 28, 2023
@Andersson007 Andersson007 mentioned this pull request Nov 28, 2023
Closed
2 tasks
@sean-m-sullivan
Copy link

This should be standard, just adds it to our documentation.

@gotmax23
Copy link
Collaborator

Please discuss on https://forum.ansible.com/t/collection-inclusion-requirements-add-requirements-txt-and-bindep-txt/2611/. I'll mark this as a draft. Thanks @Andersson007!

@gotmax23 gotmax23 marked this pull request as draft November 28, 2023 16:47
@Andersson007
Copy link
Contributor Author

PTAL, the example content in collection_template will be available after ansible-collections/collection_template#66 gets merged

@Andersson007
Copy link
Contributor Author

@sean-m-sullivan @felixfontein @gotmax23 as ansible/ansible-builder#635 has been recently merged, I've updated this PR adding a reference to the updated builders metadata guide.
If no objections, I'll open a vote on merging this in https://forum.ansible.com/t/collection-inclusion-requirements-add-requirements-txt-and-bindep-txt/2611/20 within a few days.

@Andersson007 Andersson007 changed the title [Needs SC vote] collection_requirements: add requirements.txt and bindep.txt [Needs SC vote] collection_requirements: add meta/execution-environments.yml Jan 10, 2024
@felixfontein
Copy link
Collaborator

The vote is open in https://forum.ansible.com/t/vote-ends-on-2024-01-17-collection-inclusion-requirements-add-requirements-txt-and-bindep-txt/2611/22 and doesn't have many votes yet, and it ends tomorrow.

felixfontein
felixfontein approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by https://forum.ansible.com/t/vote-ended-on-2024-01-17-collection-inclusion-requirements-add-requirements-txt-and-bindep-txt/2611/25.

@felixfontein felixfontein added the backport-2.16 Automatically create a backport for the stable-2.16 branch label Jan 17, 2024
@felixfontein felixfontein changed the title [Needs SC vote] collection_requirements: add meta/execution-environments.yml collection_requirements: add meta/execution-environments.yml Jan 17, 2024
@felixfontein felixfontein marked this pull request as ready for review January 17, 2024 11:57
@felixfontein felixfontein merged commit bed2f27 into ansible:devel Jan 17, 2024
8 checks passed
@patchback Patchback
Copy link

patchback bot commented Jan 17, 2024 •
edited
Loading

Backport to stable-2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.16/bed2f270055721d0a2b5d879f51c9a6e71239f5d/pr-871

Backported as #1048

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@Andersson007 @sean-m-sullivan @gotmax23 thanks!

patchback bot pushed a commit that referenced this pull request Jan 17, 2024
@Andersson007 @patchback
collection_requirements: add meta/execution-environments.yml (#871)
b6ac1d7 
* collection_requirements: add requirements.txt and bindep.txt

* Change

* Fix

* Update wrt recent builder docs update

(cherry picked from commit bed2f27)
@patchback patchback bot mentioned this pull request Jan 17, 2024
Merged
1 task
felixfontein pushed a commit that referenced this pull request Jan 17, 2024
@patchback @Andersson007
collection_requirements: add meta/execution-environments.yml (#871) (#…
104d8af 
…1048)

* collection_requirements: add requirements.txt and bindep.txt

* Change

* Fix

* Update wrt recent builder docs update

(cherry picked from commit bed2f27)

Co-authored-by: Andrew Klychkov <[email protected]>
oraNod pushed a commit to BhattacharjeeSutapa/ansible-documentation that referenced this pull request Feb 12, 2024
@Andersson007 @oraNod
collection_requirements: add meta/execution-environments.yml (ansible…
5314af8 
…#871)

* collection_requirements: add requirements.txt and bindep.txt

* Change

* Fix

* Update wrt recent builder docs update
@Andersson007 Andersson007 mentioned this pull request Mar 27, 2024
Closed
@Andersson007 Andersson007 mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-m-sullivan sean-m-sullivan sean-m-sullivan approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-2.16 Automatically create a backport for the stable-2.16 branch sc_approval This PR requires approval from the Ansible Community Steering Committee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Andersson007 @sean-m-sullivan @gotmax23 @felixfontein