-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AAP-10738 DROOLS-7475 Proposed feature for ['key'] accessor #539
Conversation
I would add e2e test cases, specially to ensure the new accessor works combined with filters like selectattr, e.g: https://github.com/ansible/ansible-rulebook/blob/main/tests/e2e/files/rulebooks/operators/test_selectattr_operator.yml |
Done with 36ecfd6 Naturally because of these new e2e test will now require first the merge of: |
done with 68cc376 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment regarding the changelog, otherwise LGTM
- avoid internal jiras notatio - consistent terminology to doc and playbook doc
need to incorporate: - kiegroup/drools-ansible-rulebook-integration#65 - ansible/drools_jpy#51 for a indexing fix to support once_after properly
required bump of drools_jpy from 51e04f9 tested, in full, locally: |
I'd like to get these tests passing before approving and merging. |
As mentioned in exchanges, the tests are failing because:
it needs the drools_jpy being published. |
work-in-progress as i'm volunteering to work on this e2e, so this is a quite-complete draft for the ansible-rulebook side; i'll keep posted as i will progress on drools-ansible-rulebook-integration side.
EDIT: demonstrate working locally and added e2e test as requested
JIRA: https://issues.redhat.com/browse/DROOLS-7475
referenced Pull Requests: