Enforce that Projects Persistance SC is only set to be RWX #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rooftopcellist
force-pushed
the
restrict-projects-persistance-rwx
branch
from
f2b3248 to
681e8e4
Compare
|
I think this PR is unneeded because there is a somewhat valid use case for using RWO for the projects persistence PVC. I don't think that the web container needs access to /var/lib/awx/projects. If it doesn't, then we can just remove the volume mount from the web deployment and solve this issue that way. If so, I think we should just remove the projects_persistence mounts from the web container and keep providing the ability to use a RWO PVC for projects persistence. If RWX is not available, it still stands that the user would need to set node_selector for the task pod if replicas is set > 1 so that all of those pods get scheduled on the same node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Now that web and task are now separate deployments, ReadWriteOnce is no longer a valid option for the projects persistence feature since the mounted
/projectsdirectory will be accessed by pods from different deployments now. ReadWriteMany is required. As such, we should validate that this is set as ReadWriteMany, and deprecate this parameter in the future.ISSUE TYPE