-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add directory option for receptors data #1661
Conversation
3ff81e0
to
5236c3e
Compare
@@ -889,6 +889,11 @@ spec: | |||
x-descriptors: | |||
- urn:alm:descriptor:com.tectonic.ui:advanced | |||
- urn:alm:descriptor:com.tectonic.ui:hidden | |||
- displayName: Receptor Persistant Data Directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its not persistent since /var/run/receptor is an empty dir mount
roles/installer/defaults/main.yml
Outdated
@@ -458,6 +458,8 @@ host_aliases: '' | |||
|
|||
receptor_log_level: info | |||
|
|||
receptor_datadir: /var/run/receptor/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will make it that by default we log into the directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not logs, but it will make us by default save all the contents of the /tmp/receptor/NODEID/WORKID/*
to /var/run/receptor
instead
what goes into the datadir? is it just the log? by default on kube i think receptor logs to STDOUT which can be accessed via having a log dir with no rotation can potentially eat up storages the way that the PR is written there's no way for people to NOT use the datadir also there's no persistent storage backing the directory which mean that data will be wiped out if the pod is deleted |
Thanks for the feedback! The receptor data dir is the location where receptor stores all data it is currently using, as you know (because you taught me) it is currently set to My description on persistent storage is incorrect and I will change it now, thanks for pointing that out. |
O that tmp dir 🤦♂️ The description of the PR mention receptor log |
cb32da6
to
db03ee4
Compare
db03ee4
to
d15a5ea
Compare
bcaa8dc
to
0874c0a
Compare
0874c0a
to
dfa412c
Compare
outside the scope of what is needed, containerised is not needed right now, closing |
SUMMARY
Adding option for setting receptors
datadir
option which will allow users to set the location of their receptor data. The default is/tmp/receptor/
which may not be the best option for some customers.ISSUE TYPE
ADDITIONAL INFORMATION
Tested locally by editing my
awx-demo.yml
with the following varreceptor_datadir
underspec