Fix PG Restore Force Drop DB flag #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rooftopcellist
requested review from
chrismeyersfsu,
dsavineau and
TheRealHaoLiu
rooftopcellist
force-pushed
the
rethink-restore-code
branch
from
df9b978 to
2c70d07
Compare
chrismeyersfsu
approved these changes
Dec 8, 2023
- Previously, if the flag was set to true, the bash conditional failed because the boolean was not correctly interpreted. - Use pg_restore return code to determine if the task should be marked as failed Signed-off-by: Christian M. Adams <[email protected]>
rooftopcellist
force-pushed
the
rethink-restore-code
branch
from
2c70d07 to
15e0d89
Compare
|
@chrismeyersfsu Thanks for the help and the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow-up for #1639
ISSUE TYPE