-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
move inv and cred plugins into awx_plugins
- Loading branch information
1 parent
96a3938
commit 83efafc
Showing
13 changed files
with
993 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...main/credential_plugins/centrify_vault.py → ...awx_plugins/credentials/centrify_vault.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
awx/main/credential_plugins/dsv.py → src/awx_plugins/credentials/dsv.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
This stub is only used in https://github.com/ansible/awx-plugins/blob/87cfd10/src/awx_plugins/credentials/dsv.py#L94-L102 and is actually never set anywhere, so the behavior is not branchy and always skips that if-block.
Coverage data also supports my observation that the code branch is unreachable within this repo: https://app.codecov.io/gh/ansible/awx-plugins/commit/87cfd1097291f060e6e9680bafdea6a65652a754/blob/src/awx_plugins/credentials/dsv.py?flags[0]=pytest#L95.
Git paleontology led me to ansible/awx@a317b6b#diff-db8fce7cd0a0837a198e93d45d9a620c2ccf58c8d319626aa6757677d03fb303R41-R49 which clearly depends on global Django settings.
And the stub introduced here is a no-op. It's never imported or set within AWX.