-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move inventory and credential plugins docs to awx-plugins
#27
Conversation
kubectl and synchronize are now part of community.kubernetes and ansible.posix collections, respectively. This change installs these collections to a local directory to be used in inventory and isolated management playbooks. awx issue #6930
Vendor collections for isolated jobs to work in ansible 2.10 Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
Remove inventory-related docs which are outdated or wrong SUMMARY Around 10% of this is updating docs for #9822 The rest of it is updating for changes that took place long ago, but docs still has stuff which is now wrong. ISSUE TYPE Docs Pull Request COMPONENT NAME API Reviewed-by: Chris Meyers <None>
Downstream fixes Reviewed-by: Rebeccah Hunter <[email protected]> Reviewed-by: Alan Rominger <[email protected]> Reviewed-by: Tiago Góes <[email protected]> Reviewed-by: Christian Adams <[email protected]>
- Made the choice not to pull in the CI tools due to the possibility of it blocking PRs. Co-Authored By: Lila Yasin <[email protected]>
Co-authored-by: Thanhnguyet Vo <[email protected]> Co-authored-by: TVo <[email protected]>
Signed-off-by: maskboyAvi <[email protected]>
…s.rst (#14527) Signed-off-by: maskboyAvi <[email protected]> Co-authored-by: Don Naro <[email protected]>
* Add TLS certificate auth for HashiCorp Vault Add support for AWX to authenticate with HashiCorp Vault using TLS client certificates. Also updates the documentation for the HashiCorp Vault secret management plugins to include both the new TLS options and the missing Kubernetes auth method options. Signed-off-by: Andrew Austin <[email protected]> * Refactor docker-compose vault for TLS cert auth Add TLS configuration to the docker-compose Vault configuration and use that method by default in vault plumbing. This ensures that the result of bringing up the docker-compose stack with vault enabled and running the plumb-vault playbook is a fully working credential retrieval setup using TLS client cert authentication. Signed-off-by: Andrew Austin <[email protected]> * Remove incorrect trailing space Co-authored-by: Hao Liu <[email protected]> * Make vault init idempotent - improve error handling for vault_initialization - ignore error if vault cert auth is already configured - removed unused register * Add VAULT_TLS option Make TLS for HashiCorp Vault optional and configurable via VAULT_TLS env var * Add retries for vault init Sometime it took longer for vault to fully come up and init will fail --------- Signed-off-by: Andrew Austin <[email protected]> Co-authored-by: Hao Liu <[email protected]> Co-authored-by: Hao Liu <[email protected]>
…#14654) * Add username and password to handle_auth and update exception message Revise naming of ldap username and password * Add url for LDAP and userpass to method_auth * Add information regarding LDAP and username and password to credential plugins documentation Revise ldap_auth to userpass_auth and revised exception to better reflect functionality * Revise method_auth to ensure certs can be used with username and ensure namespace functionality is not hindered
* Added LDAP support for HashiCorp Vault lookup credential * Added LDAP support for HashiCorp Vault lookup credential * Replaced graphics and updated missing fields. * Added LDAP support for HashiCorp Vault lookup credential * Replaced graphics and updated missing fields. * Incorporated review feedback from @thedoubl3j and @djyasin.
* Added docs for terraform credential/inventory source * Updated screen captures for inventories and source to match wfjt example * Added docs for terraform credential/inventory source * Updated screen captures for inventories and source to match wfjt example * Update docs/docsite/rst/userguide/inventories.rst Co-authored-by: Aoki <[email protected]> * Revised per review feedback. * Update docs/docsite/rst/userguide/inventories.rst Co-authored-by: Helen Bailey <[email protected]> --------- Co-authored-by: Aoki <[email protected]> Co-authored-by: Helen Bailey <[email protected]>
* Backports previously approved corrections. * Deleted a blank line in inventories line 100
fix link to terraform_state inventory plugin
* Added new OpenShift Virtualization inventory source to docs. * Incorporated review feedback from @fosterseth and @TheRealHaoLiu. * Fixed link to correct kubevirt.core.kubevirt documentation.
* Replaced all references of downstream docs to upstream docs. * Update README.md Co-authored-by: Don Naro <[email protected]> * Update README.md.j2 Co-authored-by: Don Naro <[email protected]> * Update README.md.j2 Co-authored-by: Don Naro <[email protected]> * Incorpor'd review feedback from @oraNod and @samccann * Updated with agreed link (for now) until further change is needed. --------- Co-authored-by: Don Naro <[email protected]>
awx-plugins
It occurred to me that it might be a good idea to preserve some of that Git history related to the moved files. I'll see if that's possible. |
Some files are .md and some are rst - What is the ultimate plan for docs in this repo? |
@samccann I integrated |
Content looks good to me. |
6f8165b
to
21157f1
Compare
21157f1
to
12fea89
Compare
my recommendation is to remove these files from the docs build. We don't yet know how it all applies, so I would err on the side of keeping them in the repo only and not part of the awx-plugin docsite for now. |
766a124
to
ea8e16a
Compare
They're being moved from `awx` to `awx-plugins`. Co-authored-by: Sviatoslav Sydorenko <[email protected]>
ea8e16a
to
0c8daf0
Compare
@samccann I don't think it's a good idea to keep files that do nothing and aren't linted lying around in the repo. We can remove them later if that's what's needed. |
FTR here's like this bit of history got grafted into the existing Git tree: https://asciinema.org/a/675613. |
@webknjaz - I disagree. Your repo, your rules, but surfacing user documentation when we haven't decided whether there will be any gui-based user docs in this repo seems misleading imo. |
@samccann - we aren't announcing this repo yet, as far as I know. We are still telling the community this is in transition and is subject to change. Right now, the focus is to move content from the awx repo. This is accomplished by this PR. We will open a new PR to clean up this content once we know more about how these plugins are supported (UI, API, etc). In the meantime, we will have it in place so making updates to the docs will be a lot easier. |
@samccann I hear you, I was just pointing out that the PR wouldn't even be mergeable without integrations. Also, if the content shouldn't be here, it should be deleted rather than remain in the repo. That's someone else's call, though. |
Moved credential plugins and inventory plugins (inventory source) chapters from the awx user guide.
Previews: