-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entry points for supported inventory sources #61
base: devel
Are you sure you want to change the base?
Conversation
also fix inventory name to match class
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
@@ -76,7 +76,7 @@ thycotic_tss = "awx_plugins.credentials.tss:tss_plugin" | |||
aws_secretsmanager_credential = "awx_plugins.credentials.aws_secretsmanager:aws_secretmanager_plugin" | |||
|
|||
[project.entry-points."awx_plugins.inventory"] # new entry points group name | |||
azure-rm = "awx_plugins.inventory.plugins:azure_rm" | |||
azure_rm = "awx_plugins.inventory.plugins:azure_rm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests must be adjusted for this, so they don't fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which tests? When I point the requirements for awx at this branch on my repo the related tests pass. I'll run them again to confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
satellite6 = "awx_plugins.inventory.plugins:satellite6_supported" | ||
controller = "awx_plugins.inventory.plugins:controller_supported" | ||
insights = "awx_plugins.inventory.plugins:insights_supported" | ||
openshift_virtualization = "awx_plugins.inventory.plugins:openshift_virtualization_supported" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should probably be mentioned in the tests too.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
A related change for ansible/awx#15658