Add indirect node counting setting

[jessicamack]

SUMMARY

Point flag at setting to make it easier to change on the fly.

ISSUE TYPE

• Bug, Docs Fix or other nominal change

COMPONENT NAME

• Other

AWX VERSION

ADDITIONAL INFORMATION

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.25%. Comparing base (c418bc0) to head (c5ff67a).

✅ All tests successful. No failed tests found.

[AlanCoding]

This would seem to undermine the point of the flag source flags.sources.SettingsFlagsSource which is already enabled by default. If I understood correctly, this could be addressed by documenting what we already have. Also, this solution will create referential problems.

[pb82]

@jessicamack @AlanCoding there is another proposal for how to handle feature flags at install time: https://handbook.eng.ansible.com/proposals/0068-Feature-flags-configuration-at-install-time

My understanding is that this is temporary, until we have Dynaconf.

[AlanCoding]

I don't think the load order works.

https://github.com/ansible/awx/blob/devel/awx/settings/production.py

This first runs

from .defaults import *  # NOQA

So at that point you have in locals

INDIRECT_NODE_COUNTING_ENABLED = False
FLAGS = {'FEATURE_INDIRECT_NODE_COUNTING_ENABLED': [{'condition': 'boolean', 'value': False}]}

Then, in a later line

# Attempt to load settings from /etc/tower/settings.py first, followed by
# /etc/tower/conf.d/*.py.
try:
    include(settings_file, optional(settings_files), scope=locals())

I predict that would yield

INDIRECT_NODE_COUNTING_ENABLED = True
FLAGS = {'FEATURE_INDIRECT_NODE_COUNTING_ENABLED': [{'condition': 'boolean', 'value': False}]}

Now, backing all the way up to what I am interpreting to be the use case you are trying to solve:

• User sets INDIRECT_NODE_COUNTING_ENABLED = True in /etc/tower/settings.py
• User restarts services
• User now has their nodes counted by this feature

Obviously, this would need to be tested. But assuming someone goes and tests it, my expectation is that it would not work, because of the load order mechanics here.