-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aap-38589 create yolo build #15807
base: devel
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. ❌ Your project check has failed because the head coverage (53.18%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.
|
|
@@ -492,6 +492,7 @@ typing-extensions==4.12.2 | |||
# psycopg | |||
# twisted | |||
urllib3==2.3.0 | |||
PyGithub==2.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is what the license test is probably complaining about so once we get this sorted on the plugins side, we should be good to nuke this and the test should pass (I am guessing that is what it is complaining about)
@@ -2,5 +2,5 @@ git+https://github.com/ansible/system-certifi.git@devel#egg=certifi | |||
# Remove pbr from requirements.in when moving ansible-runner to requirements.in | |||
git+https://github.com/ansible/ansible-runner.git@devel#egg=ansible-runner | |||
django-ansible-base @ git+https://github.com/ansible/django-ansible-base@devel#egg=django-ansible-base[rest-filters,jwt_consumer,resource-registry,rbac,feature-flags] | |||
awx-plugins-core @ git+https://github.com/ansible/awx-plugins.git@devel#egg=awx-plugins-core | |||
awx-plugins-core @ git+https://github.com/arestlelansibletest/awx-plugins@aap-38589-github-app-cred#egg=awx-plugins-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we have talked about it but just leaving this here as a reminder, revert this back to devel once the PR merges on awx-plugins
@@ -43,6 +43,9 @@ | |||
tags: | |||
- update_git | |||
block: | |||
- debug: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to remove this ;)
@@ -645,6 +645,12 @@ def get_absolute_url(self, request=None): | |||
return reverse(view_name, kwargs={'pk': self.pk}, request=request) | |||
|
|||
|
|||
# temporary so we can test the load_credentials function for github apps. | |||
def detect_server_product_name(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for this, don't forget to remove this ;)
SUMMARY
AAP-385589 Implement GitHub App credential type - Changes needed for UI Testing
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION