Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aap-38589 create yolo build #15807

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Conversation

arrestle
Copy link
Contributor

@arrestle arrestle commented Feb 3, 2025

SUMMARY

AAP-385589 Implement GitHub App credential type - Changes needed for UI Testing

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • API
  • Controller
AWX VERSION

ADDITIONAL INFORMATION

@github-actions github-actions bot added component:api dependencies Pull requests that update a dependency file community labels Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 53.18%. Comparing base (a74e730) to head (0f8bd9b).

✅ All tests successful. No failed tests found.

❌ Your project check has failed because the head coverage (53.18%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (a74e730) and HEAD (0f8bd9b). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (a74e730) HEAD (0f8bd9b)
CI-GHA 8 7
pytest 5 4
OS-Linux 8 7

Copy link

sonarqubecloud bot commented Feb 4, 2025

@arrestle arrestle requested review from thedoubl3j and AlanCoding and removed request for thedoubl3j February 5, 2025 13:54
@@ -492,6 +492,7 @@ typing-extensions==4.12.2
# psycopg
# twisted
urllib3==2.3.0
PyGithub==2.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what the license test is probably complaining about so once we get this sorted on the plugins side, we should be good to nuke this and the test should pass (I am guessing that is what it is complaining about)

@@ -2,5 +2,5 @@ git+https://github.com/ansible/system-certifi.git@devel#egg=certifi
# Remove pbr from requirements.in when moving ansible-runner to requirements.in
git+https://github.com/ansible/ansible-runner.git@devel#egg=ansible-runner
django-ansible-base @ git+https://github.com/ansible/django-ansible-base@devel#egg=django-ansible-base[rest-filters,jwt_consumer,resource-registry,rbac,feature-flags]
awx-plugins-core @ git+https://github.com/ansible/awx-plugins.git@devel#egg=awx-plugins-core
awx-plugins-core @ git+https://github.com/arestlelansibletest/awx-plugins@aap-38589-github-app-cred#egg=awx-plugins-core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we have talked about it but just leaving this here as a reminder, revert this back to devel once the PR merges on awx-plugins

@@ -43,6 +43,9 @@
tags:
- update_git
block:
- debug:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to remove this ;)

@@ -645,6 +645,12 @@ def get_absolute_url(self, request=None):
return reverse(view_name, kwargs={'pk': self.pk}, request=request)


# temporary so we can test the load_credentials function for github apps.
def detect_server_product_name():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for this, don't forget to remove this ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community component:api dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants