fix: handling of HTTP headers in EventStreams #1396
+183
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1396 +/- ##
=======================================
Coverage 94.35% 94.35%
=======================================
Files 339 339
Lines 19972 19983 +11
=======================================
+ Hits 18844 18855 +11
Misses 1128 1128
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mkanoor
force-pushed
the
fix_headers
branch
from
424147b to
895866e
Compare
|
this change would need also update our product documentation, right? |
mkanoor
force-pushed
the
fix_headers
branch
from
895866e to
88dd6e7
Compare
Alex-Izquierdo
previously approved these changes
Sep 19, 2025
mkanoor
force-pushed
the
fix_headers
branch
from
88dd6e7 to
8934da7
Compare
bzwei
reviewed
Sep 19, 2025
To include all headers you have to explicitly set the additional_data_headers = * * If the header key is used for Authentication it will be redacted * To pick and choose which headers get included, list them as a comma delimited string in additional_data_headers e.g Host,Origin,X-Request-ID * Any header that starts with X-Envoy will be dropped
mkanoor
force-pushed
the
fix_headers
branch
from
8934da7 to
19f774c
Compare
|
bzwei
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To include all headers you have to explicitly set the
additional_data_headers = *
If the header key is used for Authentication it will be redacted
To pick and choose which headers get included, list them as a comma delimited string in additional_data_headers e.g Host,Origin,X-Request-ID
Any header that starts with X-Envoy will be dropped
X-Trusted-Proxy,X-Forwarded-For,X-Real-IP will be dropped