-
Notifications
You must be signed in to change notification settings - Fork 56
Move to Runtime Platform Flags #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
36d8e8b to
4e33539
Compare
4e33539 to
e7af0de
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1407 +/- ##
=======================================
Coverage 94.60% 94.61%
=======================================
Files 343 343
Lines 21111 21127 +16
=======================================
+ Hits 19973 19989 +16
Misses 1138 1138
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
e7af0de to
54580f0
Compare
|
@ptoscano I see that you pushed a commit, was it for updating the branch? If so, I can rebase to see if I get a green CI |
Yes, it was only a plain rebase, mostly to test recent changes to the coverage reporting for PRs to SonarQube. Apologies that I used it as guinea pig :D Since the DAB branch it points to is gone (I guess because it was merged?), maybe would you please make it build again? No pressure/hurry. Thanks! |
Signed-off-by: Fabricio Aguiar <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
54580f0 to
e83d534
Compare



Jira: https://issues.redhat.com/browse/AAP-45879
This PR moves the EDA feature flag source from Settings based feature flags, to platform database level feature flags.
This also makes gateway the provider of this data for the platform.
This is required to enable platform level feature flags.
Gateway is the provider of the feature flag value updates, and is resource synced to EDA/other components.
It can be validated and tested simply with AAP Dev, and requires the following DAB PR to be merged in beforehand -
ansible/django-ansible-base#875
Once the DAB PR is merged, I will update this PR to point back to the upstream devel branch of DAB
To test -