-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playbooks for CI checks, units and functional tests #2079
Conversation
ebab981
to
65c09c7
Compare
No-Issue Signed-off-by: James Tanner <[email protected]>
d12546c
to
9be7e55
Compare
/retest |
No-Issue Signed-off-by: James Tanner <[email protected]>
Guessing this has some dependencies?
Also, how will this interact with a running oci-env on the same machine? |
@himdel that's just a helper script i run locally that i didn't mean to commit |
Ah :) but the intended way to run this is still
?
(
🤷 EDIT: moving |
@himdel try nesting the checkout under a directory like /home/himdel/src/ ... The mount config for the container is going to mount the parent directory of the galaxy_ng checkout to /src inside the container so that it can do editable installs of adjacent projects. In your case I think it's blowing up because it's trying to bind mount /home/himdel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me 👍
mkdir ~/src
cd ~/src
git clone [email protected]:ansible/galaxy_ng.git
cd galaxy_ng/
# git fetch origin pull/2079/head && git checkout FETCH_HEAD && git checkout -b pr2079
cd dev/playbooks/
ANSIBLE="ansible-playbook -i 'localhost,' --forks=1 -vvvv"
$ANSIBLE build_container.yaml
$ANSIBLE start_container.yaml
$ANSIBLE run_unit_tests.yaml
=========== 177 passed, 25 skipped, 11 warnings in 84.25s (0:01:24) ============
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
Unit tests:
=========== 179 passed, 25 skipped, 11 warnings in 73.25s (0:01:13) ============
Functional tests:
============ 7 passed, 2 skipped, 242 warnings in 90.62s (0:01:30) =============
This is a set of playbooks, roles, files and templates that are able to spawn a container almost identical to the one generated by https://github.com/pulp/plugin_template 's scripts and then run the various checks, unit tests and functional tests. All without needing to use the files layed out by https://github.com/pulp/plugin_template
Key differences with these playbooks: