Add Node.js setup support #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
reviewed
Dec 2, 2024
.github/workflows/tox.yml
Outdated
| if: ${{ inputs.default_node != '' }} | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version-file: ${{ inputs.default_node }} |
There was a problem hiding this comment.
Just use the exact same name 'node-version-file' as argument, would make it easier to switch and expand ins. the future.
There was a problem hiding this comment.
Also modify https://github.com/ansible/team-devtools/blob/main/.github/workflows/test.yml#L14 to ensure we have at least one case where we use default value and one where we pass an argument. Created a .tool-versions file in this repo, just for testing purposes and for enabling the testing of this argument.
There was a problem hiding this comment.
@ssbarnea I have made the suggested changes..
ssbarnea
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.