Always quote extra vars to support values with spaces (#57)

* Always quote extra vars to support values with spaces * Ensure extra vars are quoted This fixes a bug when the values in extra vars have spaces in them. --------- Co-authored-by: Mike Graves <[email protected]>
ansible · Apr 4, 2024 · e57ffda · e57ffda
1 parent 144251b
commit e57ffda
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/changelogs/fragments/quote-extra-vars.yml b/changelogs/fragments/quote-extra-vars.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - ensure extra vars are quoted (https://github.com/ansible/terraform-provider-ansible/pull/57).
diff --git a/provider/resource_playbook.go b/provider/resource_playbook.go
@@ -458,7 +458,7 @@ func resourcePlaybookCreate(ctx context.Context, data *schema.ResourceData, meta
 				})
 			}
 
-			args = append(args, "-e", key+"="+tmpVal)
+			args = append(args, "-e", fmt.Sprintf("%s='%s'", key, tmpVal))
 		}
 	}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- ensure extra vars are quoted (https://github.com/ansible/terraform-provider-ansible/pull/57).
-Original file line number
+Diff line change
@@ Expand Up @@
     				})
     			}
-    			args = append(args, "-e", key+"="+tmpVal)
+    			args = append(args, "-e", fmt.Sprintf("%s='%s'", key, tmpVal))
     		}
     	}
@@ Expand Down @@