Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable antsibull-changelog and add GitHub workflow for changelog validation #78

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

alinabuzachis
Copy link
Contributor

Enable antsibull-changelog and add GitHub workflow for changelog validation

@@ -0,0 +1,2 @@
breaking_changes:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this should be treated as a breaking, this is an internal change that has no impact on how the end user may use the provider.

@@ -0,0 +1,2 @@
breaking_changes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also should not be a breaking change. There should be no change from the end user's standpoint.

Copy link
Contributor Author

@alinabuzachis alinabuzachis Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought users were forced to update their dependency versions while switching from one version of another. Is it a major_change instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users don't have to update any dependencies. We're distributing a binary that has all the dependencies built into it. As far as the user is concerned, it's just a new version of the provider that works just like the old version.

@@ -0,0 +1,2 @@
trivial:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
trivial:
minor_changes:

@@ -0,0 +1,2 @@
trivial:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
trivial:
minor_changes:

@alinabuzachis alinabuzachis requested a review from abikouo February 7, 2024 10:36
@alinabuzachis alinabuzachis merged commit 655ad5e into ansible:main Feb 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants