-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable antsibull-changelog and add GitHub workflow for changelog validation #78
Conversation
4211690
to
41d5121
Compare
changelogs/fragments/use_sdkv2.yml
Outdated
@@ -0,0 +1,2 @@ | |||
breaking_changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this should be treated as a breaking, this is an internal change that has no impact on how the end user may use the provider.
@@ -0,0 +1,2 @@ | |||
breaking_changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one also should not be a breaking change. There should be no change from the end user's standpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought users were forced to update their dependency versions while switching from one version of another. Is it a major_change instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users don't have to update any dependencies. We're distributing a binary that has all the dependencies built into it. As far as the user is concerned, it's just a new version of the provider that works just like the old version.
changelogs/fragments/use_sdkv2.yml
Outdated
@@ -0,0 +1,2 @@ | |||
trivial: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trivial: | |
minor_changes: |
@@ -0,0 +1,2 @@ | |||
trivial: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trivial: | |
minor_changes: |
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
73aa04e
to
7378580
Compare
Enable antsibull-changelog and add GitHub workflow for changelog validation