Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0 #87

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Release 1.2.0 #87

merged 4 commits into from
Feb 21, 2024

Conversation

mandar242
Copy link
Contributor

  1. Updated the version number to 1.2.0
  2. Ran go generate to regenerate docs
  3. Ran antsibull-changelog release --version 1.2.0

@gravesm
Copy link
Member

gravesm commented Feb 14, 2024

Could you reissue this against the stable-1 branch? We should do releases from that.

@mandar242 mandar242 changed the base branch from main to stable-1 February 14, 2024 18:33
@sikha-root
Copy link
Contributor

Hi! I'm not sure if this affects this PR or not, but:

  • grpc 1.59.0+ (from 4m ago) needs go 1.19
  • terraform-plugin-sdk 2.32.0 (from 3w ago) needs go 1.20

go.mod currently pins this provider to 1.18, and when I personally attempted to create my own release (following the README) using the already defined GHA workflows it was failing to build on the above dependencies12. I'm not familiar with golang development but I assume this means that this project needs to be updated to use go 1.20 or 1.21?

Footnotes

  1. https://github.com/317project/terraform-provider-ansible/actions/runs/7911434107/job/21595625703

  2. https://github.com/317project/terraform-provider-ansible/actions/runs/7911584998/job/21595971910

@gravesm
Copy link
Member

gravesm commented Feb 16, 2024

@sikha-root Thanks for catching this. Yes, we need to update the version in go.mod.

@sikha-root
Copy link
Contributor

sikha-root commented Feb 16, 2024

@gravesm Should I create a new PR based off what I tried the day before yesterday? 317pr/terraform-provider-ansible@release_1_2_0_prep...317project:terraform-provider-ansible:main (ignoring the goreleaser config changes)

@gravesm
Copy link
Member

gravesm commented Feb 16, 2024

Sure, if you wouldn't mind creating a PR to update this, that would be great. I'd like to also update

to use go-version-file: 'go.mod'. This will ensure the same version is being used to run integration tests as the version being used to build releases. This way we can catch these problems sooner.

@gravesm
Copy link
Member

gravesm commented Feb 19, 2024

This PR appears to still be based off of the main branch, which is why it's duplicating commits that have been backported to the stable-1 branch. The commit that you've made should be rebased on the stable-1 branch.

@mandar242 mandar242 closed this Feb 19, 2024
@mandar242 mandar242 reopened this Feb 19, 2024
CHANGELOG.rst Show resolved Hide resolved
changelogs/changelog.yaml Outdated Show resolved Hide resolved
@mandar242 mandar242 requested a review from sikha-root February 21, 2024 17:52
@gravesm gravesm merged commit 6867292 into ansible:stable-1 Feb 21, 2024
3 checks passed
mandar242 added a commit to mandar242/terraform-provider-ansible that referenced this pull request Feb 21, 2024
* release 1.2.0

* add release-summary.yml, run antsibull-changelog release --version 1.2.0

* release date update

* add fragment for go updates, run antsibull-changelog release --version 1.2.0
gravesm pushed a commit that referenced this pull request Apr 4, 2024
* release 1.2.0

* add release-summary.yml, run antsibull-changelog release --version 1.2.0

* release date update

* add fragment for go updates, run antsibull-changelog release --version 1.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants