-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.2.0 #87
Release 1.2.0 #87
Conversation
Could you reissue this against the stable-1 branch? We should do releases from that. |
Hi! I'm not sure if this affects this PR or not, but:
go.mod currently pins this provider to 1.18, and when I personally attempted to create my own release (following the README) using the already defined GHA workflows it was failing to build on the above dependencies12. I'm not familiar with golang development but I assume this means that this project needs to be updated to use go 1.20 or 1.21? Footnotes |
@sikha-root Thanks for catching this. Yes, we need to update the version in go.mod. |
@gravesm Should I create a new PR based off what I tried the day before yesterday? 317pr/terraform-provider-ansible@release_1_2_0_prep...317project:terraform-provider-ansible:main (ignoring the goreleaser config changes) |
Sure, if you wouldn't mind creating a PR to update this, that would be great. I'd like to also update
go-version-file: 'go.mod' . This will ensure the same version is being used to run integration tests as the version being used to build releases. This way we can catch these problems sooner.
|
0fda382
to
d8e913b
Compare
This PR appears to still be based off of the main branch, which is why it's duplicating commits that have been backported to the stable-1 branch. The commit that you've made should be rebased on the stable-1 branch. |
d8e913b
to
b755d25
Compare
8d9ee5a
to
2640619
Compare
* release 1.2.0 * add release-summary.yml, run antsibull-changelog release --version 1.2.0 * release date update * add fragment for go updates, run antsibull-changelog release --version 1.2.0
1.2.0
go generate
to regenerate docsantsibull-changelog release --version 1.2.0