Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions and gRPC server #12

Merged
merged 23 commits into from
May 19, 2024
Merged

Add functions and gRPC server #12

merged 23 commits into from
May 19, 2024

Conversation

FelixKuhnAnsys
Copy link
Contributor

@FelixKuhnAnsys FelixKuhnAnsys commented May 16, 2024

  • added config
  • added dockerfile
  • populated externalfunctions (including slight changes to the functions; i.e. removal of session context)
  • added functiondefinitions to fill internalstates available functions on launch
  • added grpc protos file and generate grpcdefinition
  • added grpc server to expose three function: listFunctions, runFunction, streamFunction
  • added internalstates

@FelixKuhnAnsys FelixKuhnAnsys requested a review from a team as a code owner May 16, 2024 14:00
@wiz-inc-572fc38784
Copy link
Contributor

wiz-inc-572fc38784 bot commented May 16, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 1H 12M 2L 0I
Vulnerabilities 0C 0H 1M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 1H 13M 2L 0I
Secrets 0🔑

FelixKuhnAnsys and others added 6 commits May 16, 2024 16:01
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got some concerns here, mostly with the proto files. We shouldn't be committing the autogenerated code. We should be generating it on the fly when building the library.

Also, it seems like the docstrings are not being build into the docs. We need to modify the docs/api section to include the new sections

@FelixKuhnAnsys
Copy link
Contributor Author

I've got some concerns here, mostly with the proto files. We shouldn't be committing the autogenerated code. We should be generating it on the fly when building the library.

Also, it seems like the docstrings are not being build into the docs. We need to modify the docs/api section to include the new sections

maybe we can move the whole grpc definition to sharedtypes at a later point? otherwise we would need another public repo for it. for now andreas said to keep it here do to time constraints.

not sure where/how to modify the docs/api, maybe we can do it together on monday and you can show me? i think this can be done in a seperate pr though

@RobPasMue RobPasMue merged commit 5819ef1 into main May 19, 2024
15 checks passed
@RobPasMue RobPasMue deleted the add-functions branch May 19, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants