-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions and gRPC server #12
Conversation
FelixKuhnAnsys
commented
May 16, 2024
•
edited
Loading
edited
- added config
- added dockerfile
- populated externalfunctions (including slight changes to the functions; i.e. removal of session context)
- added functiondefinitions to fill internalstates available functions on launch
- added grpc protos file and generate grpcdefinition
- added grpc server to expose three function: listFunctions, runFunction, streamFunction
- added internalstates
Co-authored-by: Roberto Pastor Muela <[email protected]> Co-authored-by: Maxime Rey <[email protected]> Co-authored-by: klmcadams <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]> Co-authored-by: Maxime Rey <[email protected]> Co-authored-by: klmcadams <[email protected]>
Wiz Scan Summary
|
Co-authored-by: wiz-inc-572fc38784[bot] <155555808+wiz-inc-572fc38784[bot]@users.noreply.github.com>
…into add-functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got some concerns here, mostly with the proto files. We shouldn't be committing the autogenerated code. We should be generating it on the fly when building the library.
Also, it seems like the docstrings are not being build into the docs. We need to modify the docs/api section to include the new sections
maybe we can move the whole grpc definition to sharedtypes at a later point? otherwise we would need another public repo for it. for now andreas said to keep it here do to time constraints. not sure where/how to modify the docs/api, maybe we can do it together on monday and you can show me? i think this can be done in a seperate pr though |